It would be best to do this sooner rather than later so that we don't end up with too many inbound links using the current structure.
### Problem
Currently tags and authors are case sensitive and expressed in plain text resulting in ugly/fragile preview urls:
`?author=Kyle%20Drake&tags=go-ipfs,bootstrap%20nodes,breaking%20change`
### Suggestion:
Use this included `slug` module to enforce urls into lower kebab-case keys and match the objects in a case insensitive way:
`?author=kyle-drake&tags=go-ipfs,bootstrap-nodes,breaking-change`
It would be best to do this sooner rather than later so that we don't end up with too many inbound links using the current structure.
<!-- github-sync-id:859594037 -->
I think we're early enough for that not to be an issue yet, plus any unrecognised links will just fall back to the blog index.
I think we're early enough for that not to be an issue yet, plus any unrecognised links will just fall back to the blog index.
<!-- github-comment-id:821113244 -->
Suggest we do fall back for category types with spaces in them - eg news releases - as there are definitely links directly to those in circulation.
Suggest we **do** fall back for category types with spaces in them - eg news releases - as there are definitely links directly to those in circulation.
<!-- github-comment-id:821172246 -->
If it doesn't add too much complexity then yes that would be great also. It will only affect %20 items, so weighing up implementation cost against that.
If it doesn't add too much complexity then yes that would be great also. It will only affect `%20` items, so weighing up implementation cost against that.
<!-- github-comment-id:821188785 -->
@jdiogopeixoto could we also include a fix in this work for the category pages? Basically adding hard coded redirects for each page to /?category=event e.g.
I can do this quickly in the PR you create.
@jdiogopeixoto could we also include a fix in this work for the category pages? Basically adding hard coded redirects for each page to `/?category=event` e.g.
I can do this quickly in the PR you create.
<!-- github-comment-id:823460874 -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
Currently tags and authors are case sensitive and expressed in plain text resulting in ugly/fragile preview urls:
?author=Kyle%20Drake&tags=go-ipfs,bootstrap%20nodes,breaking%20changeSuggestion:
Use this included
slugmodule to enforce urls into lower kebab-case keys and match the objects in a case insensitive way:?author=kyle-drake&tags=go-ipfs,bootstrap-nodes,breaking-changeIt would be best to do this sooner rather than later so that we don't end up with too many inbound links using the current structure.
Sounds good 👍
Should we support the old format to not break old links?
I think we're early enough for that not to be an issue yet, plus any unrecognised links will just fall back to the blog index.
Suggest we do fall back for category types with spaces in them - eg news releases - as there are definitely links directly to those in circulation.
If it doesn't add too much complexity then yes that would be great also. It will only affect
%20items, so weighing up implementation cost against that.@jdiogopeixoto Just checking in on this one? Thank you!
@jessicaschilling I'm finishing the work on this one. I should be done tomorrow.
@jdiogopeixoto could we also include a fix in this work for the category pages? Basically adding hard coded redirects for each page to
/?category=evente.g.I can do this quickly in the PR you create.