mirror of
https://github.com/pdxlocations/contact.git
synced 2026-11-03 01:12:19 +01:00
Certain emoji seem to shift the text to the right #81
Assignees
adam (Adam Wojcieszonek)
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: adam/contact#81
Reference in new issue
Block a user
I'm observing that when someone does a tapback with the number of hops to reply to someone else it shifts the text display to the right. Screenshot attached.
Adding some additional context and another display item I see. When I change channels from LongFast to a trace route I did to a node you can see the Emojis still draw on the screen as well and do not clear when changing chat channels.
I am using a MAC with the terminal app which emulates xterm-256color
I also launched contact from within a screen instance
Thank you for the report. At the moment, I'm not able to reproduce this on a mac with terminal but I'll leave this open.
Oh I spoke too soon. I am now seeing some ghost emojis. Very strange!
ok let me know if I can help provide anything else. I am also running it inside of Gnu screen (https://www.gnu.org/software/screen/) which may be some of the issue also, although most ncurses stuff seems to work fine in screen.
Might I suggest/request an option to disable emojis entirely? Maybe there's a library for converting emojis into text already.
What settings are you using in Mac Terminal that you're not getting these issues? Here's what I get in Terminal.app:
Oof, removing emojis certainly would simplify things but it's one of the features of Meshtastic that drew me to the project as silly as that sounds.
I made a quick effort to use the wcwidth library to handle emoji widths but it still couldn't get it to work for emojis that use modifiers. Maybe a dictionary with a conversion table to remove the modifiers would do it?
I'm not using any special settings, maybe my meshies just use boring emojis!
My issues seem primarily related to the use of the numeric emojis, there's a bot near me that uses them to indicate hops as an emoji number, you can see those on my above screenshot. The raised hands also seems to do it. Interestingly they seem to be narrower than text spacing as those rows shorten up the rest of the row by one character.
I'm not able to reproduce the indenting, I wonder if your bot is sending more than just an emoji? Regardless, this is hopefully resolved with #252. Update Contact to V1.4.23 and please do report back. We lose flag emojis and skin tones but the layout is looking improved to me.
Things looking better for sure after updating today!
looks like those pesky flags still need some love in the node list, but we're getting close! Thanks for reporting/testing.
This happens to me when I switch to another channel and then back... Looks like it doesn't happen as much when I have it open on a bigger terminal. I'm usually in 80x25, though.
P.S. What about making ^L redraw the screen?
I see similar from my side, and sometimes garbled display when launching until I resize the terminal window to force a redraw. ^L would be a nice solve if possible.
I've seen a garbled screen on launch occasionally. I think it's when the node has received messages/packets while contact isn't running. I'll take a look, maybe we draw the screen too soon?
I found some things that may have caused that, try updating to v1.5.2
upgraded and looks good on fresh launch without any issues other than the known emoji flag item you mentioned above.
Thank you for your testing! We're now converting emoji flags to their two-letter abbreviation. The conversion doesn't feel right for node names. I don't know, maybe we can try to detect a flag and reformat the width?
It's certainly been more solid for me in 80x25.