adam/contact
1
0 Fork 0
mirror of https://github.com/pdxlocations/contact.git synced 2026-10-31 00:01:57 +01:00
Code Issues 16 Packages Projects Releases Wiki Activity

No length checking on Fixed PIN input #66

New Issue
Closed
opened 2026-10-05 03:18:49 +02:00 by adam · 4 comments
adam commented 2026-10-05 03:18:49 +02:00
Owner
Copy link
Copy source

Under Main Menu > Radio Settings > Bluetooth, Fixed PIN must be 6 digits; however, there is no length checking on this number, which can be much longer than 6 digits. It may be that none of the inputs do any validation checking, which could result in invalid configurations and much frustration for users.

Changes are probably needed in settings_menu in the file control_ui.py to implement validation checking for this and other settings.

Under Main Menu > Radio Settings > Bluetooth, Fixed PIN must be 6 digits; however, there is no length checking on this number, which can be much longer than 6 digits. It may be that none of the inputs do any validation checking, which could result in invalid configurations and much frustration for users. Changes are probably needed in settings_menu in the file control_ui.py to implement validation checking for this and other settings. <!-- github-sync-id:3254844146 -->
adam closed this issue 2026-10-05 03:18:49 +02:00
adam commented 2026-10-05 03:18:50 +02:00
Author
Owner
Copy link
Copy source

So true...

So true... <!-- github-comment-id:3115447500 -->
adam commented 2026-10-05 03:18:51 +02:00
Author
Owner
Copy link
Copy source

Work has begun on this issue in https://github.com/pdxlocations/contact/tree/input-validation

Work has begun on this issue in https://github.com/pdxlocations/contact/tree/input-validation <!-- github-comment-id:3119428860 -->
adam commented 2026-10-05 03:18:52 +02:00
Author
Owner
Copy link
Copy source

The framework is merged in #211. Fixed Pin is "fixed" :-). New rules can be added to https://github.com/pdxlocations/contact/blob/main/contact/utilities/validation_rules.py

Thanks for the nudge, I never get around to validating inputs!

The framework is merged in #211. Fixed Pin is "fixed" :-). New rules can be added to https://github.com/pdxlocations/contact/blob/main/contact/utilities/validation_rules.py Thanks for the nudge, I never get around to validating inputs! <!-- github-comment-id:3123882165 -->
adam commented 2026-10-05 03:18:53 +02:00
Author
Owner
Copy link
Copy source

Awesome!

Awesome! <!-- github-comment-id:3123904529 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/contact#66