adam/contact
1
0 Fork 0
mirror of https://github.com/pdxlocations/contact.git synced 2026-11-03 01:12:19 +01:00
Code Issues 16 Packages Projects Releases Wiki Activity

If user enters an unset setting that is true/false, then exits without changing anything, that setting will be set to False #48

New Issue
Closed
opened 2026-10-05 03:17:42 +02:00 by adam · 3 comments
adam commented 2026-10-05 03:17:42 +02:00
Owner
Copy link
Copy source
No description provided.
<!-- github-sync-id:2965235863 -->
adam closed this issue 2026-10-05 03:17:42 +02:00
adam commented 2026-10-05 03:17:43 +02:00
Author
Owner
Copy link
Copy source

I'm not seeing this, or not understanding the issue. When I navigate to Lora -> Use modem preset, the default it True, if i exit the value stays true.

I'm not seeing this, or not understanding the issue. When I navigate to Lora -> Use modem preset, the default it True, if i exit the value stays true. <!-- github-comment-id:2771383838 -->
adam commented 2026-10-05 03:17:44 +02:00
Author
Owner
Copy link
Copy source

I think I can reproduce the described behavior. On my setup:

  • Settings > Radio Settings > Deivce_Ui
  • There are a bunch of settings labeled "Not Set" including "Alert enabled"
  • Go to "Alert enabled"
  • Press Escape or left arrow to leave without setting
  • The setting is now "False" instead of "Not Set"
  • Back out to the main settings screen
  • Drill back down to Device_Ui again
  • Setting still shows "False" instead of "Not Set"

Exiting and re-entering settings restores the setting to "Not Set", so this seems like just a display issue and not something where we're actually setting a setting that the user doesn't want to.

I think I can reproduce the described behavior. On my setup: - Settings > Radio Settings > Deivce_Ui - There are a bunch of settings labeled "Not Set" including "Alert enabled" - Go to "Alert enabled" - Press Escape or left arrow to leave without setting - The setting is now "False" instead of "Not Set" - Back out to the main settings screen - Drill back down to Device_Ui again - Setting still shows "False" instead of "Not Set" Exiting and re-entering settings restores the setting to "Not Set", so this seems like just a display issue and not something where we're actually setting a setting that the user doesn't want to. <!-- github-comment-id:2773236052 -->
adam commented 2026-10-05 03:17:44 +02:00
Author
Owner
Copy link
Copy source

fixed in 031d74a290

fixed in 031d74a2909ee6638a091fee61ddf2e2016c5b45 <!-- github-comment-id:2781227502 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/contact#48