adam/contact
1
0 Fork 0
mirror of https://github.com/pdxlocations/contact.git synced 2026-10-31 00:01:57 +01:00
Code Issues 16 Packages Projects Releases Wiki Activity

Mentions of "Femtofox" while not using Femotofox #40

New Issue
Closed
opened 2026-10-05 03:17:14 +02:00 by adam · 3 comments
adam commented 2026-10-05 03:17:14 +02:00
Owner
Copy link
Copy source

There are a few mentions of the "Femtofox" device in the help text for settings, which are displayed despite not using this client with a Femtofox device. Since this client isn't ONLY used for this device, I think we should use more generic language here - "Node" maybe?

russ@russ-desktop:~/code/curses-client-for-meshtastic$ git grep -i "fox"
localisations/en.ini:node_info_broadcast_secs, "Nodeinfo broadcast interval", "This is the number of seconds between NodeInfo message broadcasts. Femtofox will still send nodeinfo in response to new nodes on the mesh."
localisations/en.ini:hop_limit, "Hop limit", "The maximum number of intermediate nodes between Femtofox and a node it is sending to. Does not impact received messages.\n[warning]Excessive hop limit increases congestion![/warning]\nMust be between 0-7."
localisations/en.ini:admin_channel_enabled, "Enable legacy admin channel", "If the node you Femtofox needs to administer or be administered by is running 2.4.x or earlier, you should set this to enabled. Requires a secondary channel named 'admin' be present on both nodes."

There are a few mentions of the "Femtofox" device in the help text for settings, which are displayed despite not using this client with a Femtofox device. Since this client isn't ONLY used for this device, I think we should use more generic language here - "Node" maybe? russ@russ-desktop:~/code/curses-client-for-meshtastic$ git grep -i "fox" **localisations/en.ini:node_info_broadcast_secs**, "Nodeinfo broadcast interval", "This is the number of seconds between NodeInfo message broadcasts. Femtofox will still send nodeinfo in response to new nodes on the mesh." **localisations/en.ini:hop_limit**, "Hop limit", "The maximum number of intermediate nodes between Femtofox and a node it is sending to. Does not impact received messages.\n[warning]Excessive hop limit increases congestion![/warning]\nMust be between 0-7." **localisations/en.ini:admin_channel_enabled**, "Enable legacy admin channel", "If the node you Femtofox needs to administer or be administered by is running 2.4.x or earlier, you should set this to enabled. Requires a secondary channel named 'admin' be present on both nodes." <!-- github-sync-id:2929427307 -->
adam closed this issue 2026-10-05 03:17:14 +02:00
adam commented 2026-10-05 03:17:15 +02:00
Author
Owner
Copy link
Copy source

Good catch, I haven't looked through the file aside from basic testing.

@rfschmid femtofox is now installing "control" on their boards as the default node config tool but I do think we should keep the text more generic so it makes sense for other platforms. They're pulling from https://github.com/pdxlocations/control which should be mostly in sync with the settings portion of Contact.

@noon92 any concerns pulling femtofox references out of the help texts in Control?

Good catch, I haven't looked through the file aside from basic testing. @rfschmid femtofox is now installing "control" on their boards as the default node config tool but I do think we should keep the text more generic so it makes sense for other platforms. They're pulling from https://github.com/pdxlocations/control which should be mostly in sync with the settings portion of Contact. @noon92 any concerns pulling femtofox references out of the help texts in Control? <!-- github-comment-id:2734325441 -->
adam commented 2026-10-05 03:17:16 +02:00
Author
Owner
Copy link
Copy source

Aha, good point. I just copied the original text I had in the hardcoded settings menu. Definitely remove references.

Sorry!

Aha, good point. I just copied the original text I had in the hardcoded settings menu. Definitely remove references. Sorry! <!-- github-comment-id:2734418901 -->
adam commented 2026-10-05 03:17:17 +02:00
Author
Owner
Copy link
Copy source

fixed in 3be31698df

fixed in 3be31698dfcbdc6761cc1d1b7ccf2966f7d6acd2 <!-- github-comment-id:2749870014 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/contact#40