If some problem occurs and videos are not uploaded, next time it will not retry because channels_timestamps.csv have been updated.
If some problem occurs and videos are not uploaded, next time it will not retry because channels_timestamps.csv have been updated.
<!-- github-sync-id:537749964 -->
This is due to the fact that channels_timestamps is updated prior to actual video handling, this is an architectural issue. I will get it fixed but it will be handled after all my existing open issues.
This is due to the fact that channels_timestamps is updated prior to actual video handling, this is an architectural issue. I will get it fixed but it will be handled after all my existing open issues.
<!-- github-comment-id:565695710 -->
The problem with this proposed change is that, suppose there are 3 videos from a channel in the queue, and the 2nd one is not uploaded. If channels_timestamps is not updated until upload is complete, then the bot will upload a duplicate of the 3rd video.
The proper approach to this problem is not to change the procedural point at which the channels_timestamps is modified (currently it is modified when the queue is created), but to handle the error properly when the video cannot be mirrored and attempt again, attempt the alternate YT URL, then if PeerTube returns some error such as upload cap reached, log the failure and either attempt it again later or leave it as is.
Related: #4 error handling.
The problem with this proposed change is that, suppose there are 3 videos from a channel in the queue, and the 2nd one is not uploaded. If channels_timestamps is not updated until upload is complete, then the bot will upload a duplicate of the 3rd video.
The proper approach to this problem is not to change the procedural point at which the channels_timestamps is modified (currently it is modified when the queue is created), but to handle the error properly when the video cannot be mirrored and attempt again, attempt the alternate YT URL, then if PeerTube returns some error such as upload cap reached, log the failure and either attempt it again later or leave it as is.
<!-- github-comment-id:565696598 -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
If some problem occurs and videos are not uploaded, next time it will not retry because channels_timestamps.csv have been updated.
This is due to the fact that channels_timestamps is updated prior to actual video handling, this is an architectural issue. I will get it fixed but it will be handled after all my existing open issues.
Related: #4 error handling.
The problem with this proposed change is that, suppose there are 3 videos from a channel in the queue, and the 2nd one is not uploaded. If channels_timestamps is not updated until upload is complete, then the bot will upload a duplicate of the 3rd video.
The proper approach to this problem is not to change the procedural point at which the channels_timestamps is modified (currently it is modified when the queue is created), but to handle the error properly when the video cannot be mirrored and attempt again, attempt the alternate YT URL, then if PeerTube returns some error such as upload cap reached, log the failure and either attempt it again later or leave it as is.
Issue #4 mirror failure still needs to be retried with alternate YT URL upon failure.