Not sure when it broke (or if it ever worked), but clicking on the clock/A-Z in repeater or contacts doesn't seem to change anything -- it's always A-Z.
(Note: Channels sorting DOES work)
I'm 99% sure there was a brand new contact in the last few hours, so would have expected that contact to have bubbled to the top in a "sort by recent".
Oh, and you fixed the sort toggling changing both contacts+repeaters together. Yay!
Not sure when it broke (or if it ever worked), but clicking on the clock/A-Z in repeater or contacts doesn't seem to change anything -- it's always A-Z.
(Note: Channels sorting DOES work)
I'm 99% sure there was a brand new contact in the last few hours, so would have expected that contact to have bubbled to the top in a "sort by recent".
Environment:
* commit bc16d804e (inside docker)
* desktop browser (Chrome)
Oh, and you fixed the sort toggling changing both contacts+repeaters together. Yay!
<!-- github-sync-id:4089046845 -->
So this is by design, but maybe the design is not great. We always sort on last heard message -- after we sort by how recently a message was exchanged, we fall back to alphabetical, not on advert. My thinking was that contacts who you've DM'd should always be closer to the top than some random contact that just advert'd. Perhaps we should fall back to advert recency, not alphabetical, after we've done message sorting.
So this is by design, but maybe the design is not great. We always sort on last heard *message* -- after we sort by how recently a message was exchanged, we fall back to alphabetical, not on advert. My thinking was that contacts who you've DM'd should always be closer to the top than some random contact that just advert'd. Perhaps we should fall back to advert recency, not alphabetical, after we've done message sorting.
<!-- github-comment-id:4076772285 -->
Ah, that makes sense for contacts! But does that make sense for repeaters?
Now I'm wondering if it's worth making it a 3-way mode for Contacts (DM recent; advert recent; A-Z)
Ah, that makes sense for contacts! But does that make sense for repeaters?
Now I'm wondering if it's worth making it a 3-way mode for Contacts (DM recent; advert recent; A-Z)
<!-- github-comment-id:4076855405 -->
Well we would probably have very very few manual contacts we've never heard an advert for OR messaged, but yeah A-Z fallback if we have added a contact that we've never messaged and never heard an advert for is reasonable.
Well we would probably have very very few manual contacts we've never heard an advert for OR messaged, but yeah A-Z fallback if we have added a contact that we've never messaged and never heard an advert for is reasonable.
<!-- github-comment-id:4076909680 -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Not sure when it broke (or if it ever worked), but clicking on the clock/A-Z in repeater or contacts doesn't seem to change anything -- it's always A-Z.
(Note: Channels sorting DOES work)
I'm 99% sure there was a brand new contact in the last few hours, so would have expected that contact to have bubbled to the top in a "sort by recent".
Environment:
bc16d804e(inside docker)Oh, and you fixed the sort toggling changing both contacts+repeaters together. Yay!
So this is by design, but maybe the design is not great. We always sort on last heard message -- after we sort by how recently a message was exchanged, we fall back to alphabetical, not on advert. My thinking was that contacts who you've DM'd should always be closer to the top than some random contact that just advert'd. Perhaps we should fall back to advert recency, not alphabetical, after we've done message sorting.
Bugfix: sort on true last-heard (i.e. adverts) after message recency, instead of alphabetically.
Ah, that makes sense for contacts! But does that make sense for repeaters?
Now I'm wondering if it's worth making it a 3-way mode for Contacts (DM recent; advert recent; A-Z)
Well we would probably have very very few manual contacts we've never heard an advert for OR messaged, but yeah A-Z fallback if we have added a contact that we've never messaged and never heard an advert for is reasonable.