adam/Remote-Terminal-for-MeshCore
1
0 Fork 0
mirror of https://github.com/jkingsman/Remote-Terminal-for-MeshCore.git synced 2026-11-03 08:02:19 +01:00
Code Issues 26 Packages Projects Releases Wiki Activity

Broken Received Advert packets added as valid #228

New Issue
Closed
opened 2026-10-05 02:04:50 +02:00 by adam · 2 comments
adam commented 2026-10-05 02:04:50 +02:00
Owner
Copy link
Copy source

Broken by other repeaters advert packet cause collisions on remote term. Someting wrong (check is hash/sign valid? order of checks etc) because other nodes dont add this broken packets as valid node.

Image

Heard:
acab88db21e38a826d50db6252d7a8dce79e0af1fe6ffc540200219d8a539d07
Heard:
acab88db21e38a826d50db6252d7a8dce79e0af1fe6ffc540200219d4146deb0
Heard:
acab88db21e38a826d50db6240024ddce79e0af1fe6ffc540200219d8a539d07

so as client adverts too.

Image

da9cf77d1b0d984c665b4d045c90603ba577f69c1c19452084935793b05a3901
and
da9cf77d1b0d90603ba54d045c90603ba577f69c1c19452084935793b05a3901

Broken by other repeaters advert packet cause collisions on remote term. Someting wrong (check is hash/sign valid? order of checks etc) because other nodes dont add this broken packets as valid node. <img width="381" height="171" alt="Image" src="https://github.com/user-attachments/assets/15f7fa39-50c2-4b5a-bb8c-90a1440d02e7" /> Heard: acab88db21e38a826d50db6252d7a8dce79e0af1fe6ffc540200219d8a539d07 Heard: acab88db21e38a826d50db6252d7a8dce79e0af1fe6ffc540200219d4146deb0 Heard: acab88db21e38a826d50db6240024ddce79e0af1fe6ffc540200219d8a539d07 so as client adverts too. <img width="281" height="400" alt="Image" src="https://github.com/user-attachments/assets/69a1cbe2-c8e2-4f4f-b947-6d6a03c79fca" /> da9cf77d1b0d984c665b4d045c90603ba577f69c1c19452084935793b05a3901 and da9cf77d1b0d90603ba54d045c90603ba577f69c1c19452084935793b05a3901 <!-- github-sync-id:4794280971 -->
adam closed this issue 2026-10-05 02:04:50 +02:00
adam commented 2026-10-05 02:04:51 +02:00
Author
Owner
Copy link
Copy source

i'm seeing same behavior

Image
i'm seeing same behavior <img width="356" height="372" alt="Image" src="https://github.com/user-attachments/assets/563cc24c-b370-4bec-8a9a-daad9095fd22" /> <!-- github-comment-id:4875335957 -->
adam commented 2026-10-05 02:04:51 +02:00
Author
Owner
Copy link
Copy source

So those are just keys; I can't include your exact bad packets in the tests without the whole packet, but I've added some more aggressive packet signature validation that should hopefully prevent this.

So those are just keys; I can't include your exact bad packets in the tests without the whole packet, but I've added some more aggressive packet signature validation that should hopefully prevent this. <!-- github-comment-id:4919700718 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Remote-Terminal-for-MeshCore#228