adam/Remote-Terminal-for-MeshCore
1
0
Fork 0
mirror of https://github.com/jkingsman/Remote-Terminal-for-MeshCore.git synced 2026-07-31 05:53:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix busted tests

Browse Source
This commit is contained in:
Jack Kingsman
2026-07-25 21:02:53 -07:00
parent d267075127
commit fc8dec3417
3 changed files with 29 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/specs/channel-info-and-search.spec.ts
+4 -2
View File
@@ -37,8 +37,10 @@ test.describe('Channel info pane', () => {
await page.goto(`/#channel/${channelKey}/flightless`);
await expect(page.getByRole('status', { name: 'Radio OK' })).toBeVisible();
// Wait for messages to load
await expect(page.getByText('seed-0')).toBeVisible({ timeout: 15_000 });
// Wait for messages to load. Assert on the newest seeded message, not the
// oldest: the list is virtualized, so it opens at the bottom and only the
// visible window is in the DOM — seed-0 is 30 rows up and legitimately absent.
await expect(page.getByText(`seed-${SEED_COUNT - 1}`)).toBeVisible({ timeout: 15_000 });
// Click the channel name in the header to open info pane
const headerTitle = page.locator('h2').filter({ hasText: '#flightless' });
tests/e2e/specs/pagination.spec.ts
+14 -7
View File
@@ -25,13 +25,20 @@ test.describe('Message pagination ordering/dedup', () => {
const list = page.locator('div.h-full.overflow-y-auto').first();
// Scroll to top to trigger older fetch
await list.evaluate((el) => {
el.scrollTop = 0;
});
// Wait for oldest message to appear after pagination
await expect(page.getByText('seed-0')).toBeVisible({ timeout: 15_000 });
// Scroll to top repeatedly until the oldest message renders.
//
// One scroll is not enough with a virtualized list: reaching the top fetches
// the older page, and the list then anchors to the message that was on top so
// the reader keeps their place, which leaves seed-0 fifty rows further up and
// unmounted. A reader scrolls again to get there; so does this. (Before
// virtualization every loaded row was in the DOM, so a single scroll made
// seed-0 findable regardless of where the viewport actually was.)
await expect(async () => {
await list.evaluate((el) => {
el.scrollTop = 0;
});
await expect(page.getByText('seed-0')).toBeVisible({ timeout: 1_000 });
}).toPass({ timeout: 20_000 });
// Spot-check ordering: seed-249 appears above seed-200; seed-50 above seed-10
// Fetch from API to validate ordering and dedup