Misc. doc, test, and qol improvements

app/AGENTS.md

@@ -8,7 +8,7 @@ Keep it aligned with `app/` source files and router behavior.
 - FastAPI
 - aiosqlite
 - Pydantic
-- MeshCore Python library (`references/meshcore_py`)
+- MeshCore Python library (`meshcore` from PyPI)
 - PyCryptodome
 
 ## Backend Map

app/radio_sync.py

@@ -443,6 +443,8 @@ async def _periodic_advert_loop():
     """
     while True:
         try:
+            await asyncio.sleep(ADVERT_CHECK_INTERVAL)
+
             # Try to send - send_advertisement() handles all checks
             # (disabled, throttled, not connected)
             if radio_manager.is_connected:
@@ -455,9 +457,6 @@ async def _periodic_advert_loop():
                 except RadioOperationBusyError:
                     logger.debug("Skipping periodic advertisement: radio busy")
 
-            # Sleep before next check
-            await asyncio.sleep(ADVERT_CHECK_INTERVAL)
-
         except asyncio.CancelledError:
             logger.info("Periodic advertisement task cancelled")
             break
@@ -595,9 +594,7 @@ async def _sync_contacts_to_radio_inner(mc: MeshCore) -> dict:
             break
 
     if len(selected_contacts) < max_contacts:
-        recent_contacts = await ContactRepository.get_recent_non_repeaters(
-            limit=max_contacts
-        )
+        recent_contacts = await ContactRepository.get_recent_non_repeaters(limit=max_contacts)
         for contact in recent_contacts:
             key = contact.public_key.lower()
             if key in selected_keys:
@@ -658,9 +655,7 @@ async def _sync_contacts_to_radio_inner(mc: MeshCore) -> dict:
     }
 
 
-async def sync_recent_contacts_to_radio(
-    force: bool = False, mc: MeshCore | None = None
-) -> dict:
+async def sync_recent_contacts_to_radio(force: bool = False, mc: MeshCore | None = None) -> dict:
     """
     Load contacts to the radio for DM ACK support.
 

app/routers/contacts.py

@@ -539,7 +539,9 @@ async def create_contact(
                     "last_contacted": existing.last_contacted,
                 }
             )
-            existing.name = request.name
+            refreshed = await ContactRepository.get_by_key(request.public_key)
+            if refreshed is not None:
+                existing = refreshed
 
         # Trigger historical decryption if requested (even for existing contacts)
         if request.try_historical: