Multi-ack. Closes #81.

tests/test_radio_commands_service.py

@@ -33,6 +33,7 @@ def _mock_meshcore_with_info():
     mc.commands.set_radio = AsyncMock()
     mc.commands.set_path_hash_mode = AsyncMock(return_value=_radio_result())
     mc.commands.set_advert_loc_policy = AsyncMock(return_value=_radio_result())
+    mc.commands.set_multi_acks = AsyncMock(return_value=_radio_result())
     mc.commands.send_appstart = AsyncMock()
     mc.commands.import_private_key = AsyncMock(return_value=_radio_result())
     return mc
@@ -84,6 +85,39 @@ class TestApplyRadioConfigUpdate:
         mc.commands.set_advert_loc_policy.assert_awaited_once_with(1)
         mc.commands.send_appstart.assert_awaited_once()
 
+    @pytest.mark.asyncio
+    async def test_updates_multi_acks_enabled(self):
+        mc = _mock_meshcore_with_info()
+
+        await apply_radio_config_update(
+            mc,
+            RadioConfigUpdate(multi_acks_enabled=True),
+            path_hash_mode_supported=True,
+            set_path_hash_mode=MagicMock(),
+            sync_radio_time_fn=AsyncMock(),
+        )
+
+        mc.commands.set_multi_acks.assert_awaited_once_with(1)
+        mc.commands.send_appstart.assert_awaited_once()
+
+    @pytest.mark.asyncio
+    async def test_raises_when_radio_rejects_multi_acks(self):
+        mc = _mock_meshcore_with_info()
+        mc.commands.set_multi_acks = AsyncMock(
+            return_value=_radio_result(EventType.ERROR, {"error": "nope"})
+        )
+
+        with pytest.raises(RadioCommandRejectedError):
+            await apply_radio_config_update(
+                mc,
+                RadioConfigUpdate(multi_acks_enabled=False),
+                path_hash_mode_supported=True,
+                set_path_hash_mode=MagicMock(),
+                sync_radio_time_fn=AsyncMock(),
+            )
+
+        mc.commands.send_appstart.assert_not_awaited()
+
     @pytest.mark.asyncio
     async def test_raises_when_radio_rejects_advert_location_source(self):
         mc = _mock_meshcore_with_info()

tests/test_radio_router.py

@@ -75,6 +75,7 @@ def _mock_meshcore_with_info():
         "radio_sf": 7,
         "radio_cr": 5,
         "adv_loc_policy": 2,
+        "multi_acks": 0,
     }
     mc.commands = MagicMock()
     mc.commands.set_name = AsyncMock()
@@ -82,6 +83,7 @@ def _mock_meshcore_with_info():
     mc.commands.set_tx_power = AsyncMock()
     mc.commands.set_radio = AsyncMock()
     mc.commands.set_advert_loc_policy = AsyncMock(return_value=_radio_result())
+    mc.commands.set_multi_acks = AsyncMock(return_value=_radio_result())
     mc.commands.send_appstart = AsyncMock()
     mc.commands.import_private_key = AsyncMock(return_value=_radio_result())
     mc.commands.send_node_discover_req = AsyncMock(return_value=_radio_result())
@@ -104,6 +106,17 @@ class TestGetRadioConfig:
         assert response.radio.freq == 910.525
         assert response.radio.cr == 5
         assert response.advert_location_source == "current"
+        assert response.multi_acks_enabled is False
+
+    @pytest.mark.asyncio
+    async def test_maps_multi_acks_to_response(self):
+        mc = _mock_meshcore_with_info()
+        mc.self_info["multi_acks"] = 1
+
+        with patch("app.routers.radio.require_connected", return_value=mc):
+            response = await get_radio_config()
+
+        assert response.multi_acks_enabled is True
 
     @pytest.mark.asyncio
     async def test_maps_any_nonzero_advert_location_policy_to_current(self):
@@ -172,6 +185,7 @@ class TestUpdateRadioConfig:
             path_hash_mode=0,
             path_hash_mode_supported=False,
             advert_location_source="current",
+            multi_acks_enabled=False,
         )
 
         with (
@@ -187,6 +201,36 @@ class TestUpdateRadioConfig:
         mc.commands.set_advert_loc_policy.assert_awaited_once_with(1)
         assert result == expected
 
+    @pytest.mark.asyncio
+    async def test_updates_multi_acks_enabled(self):
+        mc = _mock_meshcore_with_info()
+        expected = RadioConfigResponse(
+            public_key="aa" * 32,
+            name="NodeA",
+            lat=10.0,
+            lon=20.0,
+            tx_power=17,
+            max_tx_power=22,
+            radio=RadioSettings(freq=910.525, bw=62.5, sf=7, cr=5),
+            path_hash_mode=0,
+            path_hash_mode_supported=False,
+            advert_location_source="current",
+            multi_acks_enabled=True,
+        )
+
+        with (
+            patch("app.routers.radio.require_connected", return_value=mc),
+            patch.object(radio_manager, "_meshcore", mc),
+            patch("app.routers.radio.sync_radio_time", new_callable=AsyncMock),
+            patch(
+                "app.routers.radio.get_radio_config", new_callable=AsyncMock, return_value=expected
+            ),
+        ):
+            result = await update_radio_config(RadioConfigUpdate(multi_acks_enabled=True))
+
+        mc.commands.set_multi_acks.assert_awaited_once_with(1)
+        assert result == expected
+
     def test_model_rejects_negative_path_hash_mode(self):
         with pytest.raises(ValidationError):
             RadioConfigUpdate(path_hash_mode=-1)