output details on failure of pwg.images.php: ws_images_upload #962

New Issue

2026-10-05T00:25:47+02:00

adam commented

2026-10-05 00:25:47 +02:00

in ws_images_addSimple the $_FILES['image']['error'] is nicely interpreted and converted into a useful message. In ws_images_upload I request to have something similar. Maybe

  if (isset($_FILES['file']['error']) && $_FILES['file']['error'] != 0)
  {
    switch($_FILES['file']['error'])
    {
      case UPLOAD_ERR_INI_SIZE:
        $message = 'The uploaded file exceeds the upload_max_filesize directive in php.ini.';
        break;
      case UPLOAD_ERR_FORM_SIZE:
        $message = 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form.';
        break;
      case UPLOAD_ERR_PARTIAL:
        $message = 'The uploaded file was only partially uploaded.';
        break;
      case UPLOAD_ERR_NO_FILE:
        $message = 'No file was uploaded.';
        break;
      case UPLOAD_ERR_NO_TMP_DIR:
        $message = 'Missing a temporary folder.';
        break;
      case UPLOAD_ERR_CANT_WRITE:
        $message = 'Failed to write file to disk.';
        break;
      case UPLOAD_ERR_EXTENSION:
        $message = 'A PHP extension stopped the file upload. ' .
        'PHP does not provide a way to ascertain which extension caused the file ' .
        'upload to stop; examining the list of loaded extensions with phpinfo() may help.';
        break;
      default:
        $message = "Error number {$_FILES['file']['error']} occurred while uploading a file.";
    }
    die('{"jsonrpc" : "2.0", "error" : {"code": 104, "message": "' . $message . '"}, "id" : "id"}');
  }

to have a helpful output in the JSON WS interface.

in ws_images_addSimple the $_FILES['image']['error'] is nicely interpreted and converted into a useful message. In ws_images_upload I request to have something similar. Maybe ``` if (isset($_FILES['file']['error']) && $_FILES['file']['error'] != 0) { switch($_FILES['file']['error']) { case UPLOAD_ERR_INI_SIZE: $message = 'The uploaded file exceeds the upload_max_filesize directive in php.ini.'; break; case UPLOAD_ERR_FORM_SIZE: $message = 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form.'; break; case UPLOAD_ERR_PARTIAL: $message = 'The uploaded file was only partially uploaded.'; break; case UPLOAD_ERR_NO_FILE: $message = 'No file was uploaded.'; break; case UPLOAD_ERR_NO_TMP_DIR: $message = 'Missing a temporary folder.'; break; case UPLOAD_ERR_CANT_WRITE: $message = 'Failed to write file to disk.'; break; case UPLOAD_ERR_EXTENSION: $message = 'A PHP extension stopped the file upload. ' . 'PHP does not provide a way to ascertain which extension caused the file ' . 'upload to stop; examining the list of loaded extensions with phpinfo() may help.'; break; default: $message = "Error number {$_FILES['file']['error']} occurred while uploading a file."; } die('{"jsonrpc" : "2.0", "error" : {"code": 104, "message": "' . $message . '"}, "id" : "id"}'); } ``` to have a helpful output in the JSON WS interface.

Sign in to join this conversation.

master

issue-2560-people

translation

16.x

feat/embedding-based-contextual-tagging

issue-2576-search-include-ai-in-search-results

feat/search-ocr-ai

issue-2391-update-menu-design

15.x

detect-container

issue-2386-update-filters-users-activity

issue-2362-add-filters-options-in-admin

issue-2367-imagemagick7

issue-2225-quicksearch-help

14.x

issue-2164-BatchManagerUnitMode-Redesign

13.x

12.x

issue-1657-SVG_Support

issue-1703-historySearchMethod

11.x

2.10

2.9

2.8

2.7

2.5

2.6

2.4

2.3

2.2

2.1

2.0

1.7

1.3

1.6

1.5

1.4

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/Piwigo#962