[2.10] AdminTools broken on Upload form #942

Closed
opened 2026-10-05 00:24:48 +02:00 by adam · 1 comment
Owner

and also on the Batch Manager.

20190925-piwigo-2 10-bug-admintools

After deep investigation, the problem is only when Piwigo combines JS/CSS.

The bug comes from admin/themes/default/fontello/css/animation.css loaded by admin/themes/default/template/include/add_album.inc.tpl (to animate a vector icon instead of a animated GIF). The minification of animation.css breaks CSS parsing and following scripts are not correctly executed, including Admin Tools scripts.

The break of AdminTools is just the visible effect of problematic animation.css.

and also on the Batch Manager. ![20190925-piwigo-2 10-bug-admintools](https://user-images.githubusercontent.com/9326959/65608668-e1605080-dfae-11e9-872f-3729c37a286f.png) After deep investigation, the problem is only when Piwigo combines JS/CSS. The bug comes from `admin/themes/default/fontello/css/animation.css` loaded by `admin/themes/default/template/include/add_album.inc.tpl` (to animate a vector icon instead of a animated GIF). The minification of `animation.css` breaks CSS parsing and following scripts are not correctly executed, including Admin Tools scripts. The break of AdminTools is just the visible effect of problematic `animation.css`. <!-- github-sync-id:498315664 -->
adam closed this issue 2026-10-05 00:24:48 +02:00
Author
Owner

@modus75 I don't think we can consider my fix satisfactory. Can you give a look to see what is wrong with this animation.css?

@modus75 I don't think we can consider my fix satisfactory. Can you give a look to see what is wrong with this `animation.css`? <!-- github-comment-id:535049908 -->
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#942