adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-03 07:22:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

Included JShrink version issues with PHP 7.3 #845

New Issue
Closed
opened 2026-10-05 00:20:23 +02:00 by adam · 4 comments
adam commented 2026-10-05 00:20:23 +02:00
Owner
Copy link
Copy source

The included version of JShrink is over 6 years old and begins to have issues with newer PHP releases.

Users reported an issue where literal PHP deprecated warnings got merged in the the combined js file, causing javascript syntax errors. See https://github.com/tkuther/piwigo-bootstrap-darkroom/issues/185

JShrink should be upgraded to the latest version v1.3.1.

The included version of JShrink is over 6 years old and begins to have issues with newer PHP releases. Users reported an issue where literal PHP deprecated warnings got merged in the the combined js file, causing javascript syntax errors. See https://github.com/tkuther/piwigo-bootstrap-darkroom/issues/185 JShrink should be upgraded to the latest version v1.3.1. <!-- github-sync-id:394116542 -->
adam closed this issue 2026-10-05 00:20:23 +02:00
adam commented 2026-10-05 00:20:24 +02:00
Author
Owner
Copy link
Copy source

Is it possible to add a version matrix somewhere? Pretty please.

Is it possible to add a version matrix somewhere? Pretty please. <!-- github-comment-id:552752112 -->
adam commented 2026-10-05 00:20:25 +02:00
Author
Owner
Copy link
Copy source

I'm still wondering about this issue. JShrink 1.3.3 requires PHP 5.6 while Piwigo 2.10 only requires PHP 5.3.

Now, let's take Wordpress as our "lighthouse", since they're certainly leading the CMS industry and they're based on PHP. I see that since version 5.2 (May 2019, 1.5 year ago) Wordpress requires PHP 5.6 (and now recommend PHP 7.4). Maybe it's time for Piwigo to increase its requirement too!

Before doing such a big step (set PHP requirement to version 7 for example), I would like to have #769 implemented.

I'm still wondering about this issue. JShrink 1.3.3 requires PHP 5.6 while Piwigo 2.10 only requires PHP 5.3. Now, let's take Wordpress as our "lighthouse", since they're certainly leading the CMS industry and they're based on PHP. I see that since version 5.2 (May 2019, 1.5 year ago) Wordpress requires PHP 5.6 (and now recommend PHP 7.4). Maybe it's time for Piwigo to increase its requirement too! Before doing such a big step (set PHP requirement to version 7 for example), I would like to have #769 implemented. <!-- github-comment-id:701268683 -->
adam commented 2026-10-05 00:20:26 +02:00
Author
Owner
Copy link
Copy source

Let's increase the PHP required version to 7.0 for Piwigo 12.

Let's increase the PHP required version to 7.0 for Piwigo 12. <!-- github-comment-id:871275369 -->
adam commented 2026-10-05 00:20:26 +02:00
Author
Owner
Copy link
Copy source

#1310

#1310 <!-- github-comment-id:891180795 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#845