adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-02 15:02:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

API pwg.images.getInfo returns incorrect URLs with $conf['original_url_protection'] #723

New Issue
Closed
opened 2026-10-05 00:13:53 +02:00 by adam · 4 comments
adam commented 2026-10-05 00:13:53 +02:00
Owner
Copy link
Copy source

With $conf['original_url_protection']="images" (or "all"); the Piwigo API pwg.images.getInfo returns in element_url the URL …action.php?id=6&part=e instead of …action.php?id=6&part=e.

I add a patch replacing & with & in the iOS but could this be fixed?

PS: Tested with Piwigo v2.9.2

With `$conf['original_url_protection']="images" (or "all");` the Piwigo API `pwg.images.getInfo` returns in `element_url` the URL `…action.php?id=6&amp;part=e` instead of `…action.php?id=6&part=e`. I add a patch replacing `&amp;` with `&` in the iOS but could this be fixed? PS: Tested with Piwigo v2.9.2 <!-- github-sync-id:265506302 -->
adam closed this issue 2026-10-05 00:13:53 +02:00
adam commented 2026-10-05 00:13:54 +02:00
Author
Owner
Copy link
Copy source

Still an issue after 8 years 🤨

Still an issue after 8 years 🤨 <!-- github-comment-id:3625300269 -->
adam commented 2026-10-05 00:13:55 +02:00
Author
Owner
Copy link
Copy source

OK, I have also encountered the problem with theme Modus when trying to display the original size. This fixes the problem:

~/git/Piwigo[master|✚2⚑49] % git diff
diff --git a/include/functions_url.inc.php b/include/functions_url.inc.php
index 08fdbd5a9..0b6cb992a 100644
--- a/include/functions_url.inc.php
+++ b/include/functions_url.inc.php
@@ -100,7 +100,7 @@ function get_absolute_root_url($with_scheme=true)
  * @param array params
  * @return string
  */
-function add_url_params($url, $params, $arg_separator='&amp;' )
+function add_url_params($url, $params, $arg_separator='&' )
 {
   if ( !empty($params) )
   {

but I admit I don't remember why we used &amp; instead of &. I need to make more tests to see if it's safe to make this change. function add_url_params is used quite everywhere (indirectly)

OK, I have also encountered the problem with theme Modus when trying to display the original size. This fixes the problem: ``` ~/git/Piwigo[master|✚2⚑49] % git diff diff --git a/include/functions_url.inc.php b/include/functions_url.inc.php index 08fdbd5a9..0b6cb992a 100644 --- a/include/functions_url.inc.php +++ b/include/functions_url.inc.php @@ -100,7 +100,7 @@ function get_absolute_root_url($with_scheme=true) * @param array params * @return string */ -function add_url_params($url, $params, $arg_separator='&amp;' ) +function add_url_params($url, $params, $arg_separator='&' ) { if ( !empty($params) ) { ``` but I admit I don't remember why we used `&amp;` instead of `&`. I need to make more tests to see if it's safe to make this change. function `add_url_params` is used quite everywhere (indirectly) <!-- github-comment-id:4100566135 -->
adam commented 2026-10-05 00:13:55 +02:00
Author
Owner
Copy link
Copy source

I don't remember why we used &amp; instead of &

Now I remember why: in HTML, we're supposed to write &amp; in attributes (or anywhere else) to avoid confusion with the start of an HTML entity. Obviously modern web browsers don't really care and it works perfectly well by writing & instead.

I'm confused on what we should do to make things clean without breaking half of Piwigo urls (depending on the web browser or the third party app using the API)

Still working on finding a solution...

> I don't remember why we used `&amp;` instead of `&` Now I remember why: in HTML, we're supposed to write `&amp;` in attributes (or anywhere else) to avoid confusion with the start of an HTML entity. Obviously modern web browsers don't really care and it works perfectly well by writing `&` instead. I'm confused on what we should do to make things clean without breaking half of Piwigo urls (depending on the web browser or the third party app using the API) Still working on finding a solution... <!-- github-comment-id:4100732201 -->
adam commented 2026-10-05 00:13:56 +02:00
Author
Owner
Copy link
Copy source

We discussed with plg. This change is too simple and not compliant with html standards.

-function add_url_params($url, $params, $arg_separator='&amp;' )
+function add_url_params($url, $params, $arg_separator='&' )

Instead we only change the separator when we detect we're in the API.

We discussed with plg. This change is too simple and not compliant with html standards. ```php -function add_url_params($url, $params, $arg_separator='&amp;' ) +function add_url_params($url, $params, $arg_separator='&' ) ``` Instead we only change the separator when we detect we're in the API. <!-- github-comment-id:4109928344 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#723