adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-03 07:22:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

Logger.class.php should be uncapitalized #674

New Issue
Open
opened 2026-10-05 00:10:45 +02:00 by adam · 3 comments
adam commented 2026-10-05 00:10:45 +02:00
Owner
Copy link
Copy source

include/Logger.class.php

should be

include/logger.class.php

include/Logger.class.php should be include/logger.class.php <!-- github-sync-id:240902654 -->
adam commented 2026-10-05 00:10:46 +02:00
Author
Owner
Copy link
Copy source

Hi @airylinus

Can you be more specific? Why "should" it be uncapitalized? is lowercase a rule?

Hi @airylinus Can you be more specific? Why "should" it be uncapitalized? is lowercase a rule? <!-- github-comment-id:313351481 -->
adam commented 2026-10-05 00:10:47 +02:00
Author
Owner
Copy link
Copy source

@plegall hi,

I found all class files named lowercase but Logger.class.php. so I thought maybe there was a typo of file name. Not a big deal, but I think we can do better. No offense. lol . I can set up a pull request as soon as the typo confirmed.

ps: How about PSR ( PHP standard recommendation http://www.php-fig.org/psr/ ) ?

@plegall hi, I found all class files named lowercase but Logger.class.php. so I thought maybe there was a typo of file name. Not a big deal, but I think we can do better. No offense. lol . I can set up a pull request as soon as the typo confirmed. ps: How about PSR ( PHP standard recommendation [http://www.php-fig.org/psr/](http://www.php-fig.org/psr/) ) ? <!-- github-comment-id:313584854 -->
adam commented 2026-10-05 00:10:48 +02:00
Author
Owner
Copy link
Copy source

You might be referring to http://www.php-fig.org/psr/psr-1/ or http://www.php-fig.org/psr/psr-3/? It says nothing about file naming conventions.

You might be referring to http://www.php-fig.org/psr/psr-1/ or http://www.php-fig.org/psr/psr-3/? It says nothing about file naming conventions. <!-- github-comment-id:329670586 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#674