adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-31 06:02:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

replace include file='comment_list.tpl' #554

New Issue
Closed
opened 2026-10-05 00:03:45 +02:00 by adam · 8 comments
adam commented 2026-10-05 00:03:45 +02:00
Owner
Copy link
Copy source

so comment_list can be replaced via template extension or extensions
No HTML changes just tpl and php

so comment_list can be replaced via template extension or extensions No HTML changes just tpl and php <!-- github-sync-id:200466435 -->
adam closed this issue 2026-10-05 00:03:45 +02:00
adam commented 2026-10-05 00:03:46 +02:00
Author
Owner
Copy link
Copy source

I have assigned this to 2.10 since the tpl code changed a bit
awaiting CP

I have assigned this to 2.10 since the tpl code changed a bit awaiting CP <!-- github-comment-id:326615785 -->
adam commented 2026-10-05 00:03:47 +02:00
Author
Owner
Copy link
Copy source

Can we have more details on this issue? Why do we need this change? What does it imply? Do themes and plugins developers need to know about this change?

Can we have more details on this issue? Why do we need this change? What does it imply? Do themes and plugins developers need to know about this change? <!-- github-comment-id:407322701 -->
adam commented 2026-10-05 00:03:47 +02:00
Author
Owner
Copy link
Copy source

The comment_derivative_params template variable is used on the comments
page in the core default theme.
The commit from sep 2017 broke it (variable was set in the template using
{include})

The comment_derivative_params template variable is used on the comments page in the core default theme. The commit from sep 2017 broke it (variable was set in the template using {include}) > <!-- github-comment-id:407325331 -->
adam commented 2026-10-05 00:03:48 +02:00
Author
Owner
Copy link
Copy source

OK @modus75 but at the beginning, @flop25 what does this issue tries to fix? Is there a problem with the {include} directive in Smarty? (I have no idea, I'm trying to understand the origin of this issue)

OK @modus75 but at the beginning, @flop25 what does this issue tries to fix? Is there a problem with the `{include}` directive in Smarty? (I have no idea, I'm trying to understand the origin of this issue) <!-- github-comment-id:407328726 -->
adam commented 2026-10-05 00:03:49 +02:00
Author
Owner
Copy link
Copy source

Hi Thx modus
Plg: Check the comment of my commit

Le mar. 24 juil. 2018 à 15:40, Pierrick Le Gall notifications@github.com
a écrit :

OK @modus75 https://github.com/modus75 but at the beginning, @flop25
https://github.com/flop25 what does this issue tries to fix? Is there a
problem with the {include} directive in Smarty? (I have no idea, I'm
trying to understand the origin of this issue)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Piwigo/Piwigo/issues/603#issuecomment-407328726, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAs-jSWuult9JumMg9mGsmRn-pi7-2Zmks5uJt2XgaJpZM4LiLS9
.

Hi Thx modus Plg: Check the comment of my commit Le mar. 24 juil. 2018 à 15:40, Pierrick Le Gall <notifications@github.com> a écrit : > OK @modus75 <https://github.com/modus75> but at the beginning, @flop25 > <https://github.com/flop25> what does this issue tries to fix? Is there a > problem with the {include} directive in Smarty? (I have no idea, I'm > trying to understand the origin of this issue) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/Piwigo/Piwigo/issues/603#issuecomment-407328726>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAs-jSWuult9JumMg9mGsmRn-pi7-2Zmks5uJt2XgaJpZM4LiLS9> > . > <!-- github-comment-id:407353976 -->
adam commented 2026-10-05 00:03:50 +02:00
Author
Owner
Copy link
Copy source

OK, I get it :-)

OK, I get it :-) <!-- github-comment-id:407377668 -->
adam commented 2026-10-05 00:03:51 +02:00
Author
Owner
Copy link
Copy source

Thank you for your hard work Have a good summer

Le mar. 24 juil. 2018 à 18:47, Pierrick Le Gall notifications@github.com
a écrit :

OK, I get it :-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Piwigo/Piwigo/issues/603#issuecomment-407377668, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAs-jYf-sKrW9COvzbduOmO1PCt-yuevks5uJwljgaJpZM4LiLS9
.

Thank you for your hard work Have a good summer Le mar. 24 juil. 2018 à 18:47, Pierrick Le Gall <notifications@github.com> a écrit : > OK, I get it :-) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/Piwigo/Piwigo/issues/603#issuecomment-407377668>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAs-jYf-sKrW9COvzbduOmO1PCt-yuevks5uJwljgaJpZM4LiLS9> > . > <!-- github-comment-id:407377908 -->
adam commented 2026-10-05 00:03:51 +02:00
Author
Owner
Copy link
Copy source

I close this issue, it will be available starting with Piwigo 2.10.0. This change is detailed on documentation for theme developpers https://piwigo.org/doc/doku.php?id=dev:changes_in_2.10

I close this issue, it will be available starting with Piwigo 2.10.0. This change is detailed on documentation for theme developpers https://piwigo.org/doc/doku.php?id=dev:changes_in_2.10 <!-- github-comment-id:506373070 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#554