Remove "file" picture url style ? #359

New Issue

2026-10-04T23:53:56+02:00

adam commented

2026-10-04 23:53:56 +02:00

$conf['picture_url_style'] = 'file'; is too much error prone and is generally badly used

I suggest to at least remove any reference to the "file" possibility in the comment in config_default.inc.php (must leave the feature for links retro-compatibility)

`$conf['picture_url_style'] = 'file';` is too much error prone and is generally badly used I suggest to at least remove any reference to the "file" possibility in the comment in `config_default.inc.php` (must leave the feature for links retro-compatibility)

adam commented

2026-10-04 23:53:57 +02:00

I don't understand why this is "too much error prone"...

I don't understand why this is "too much error prone"...

adam commented

2026-10-04 23:53:57 +02:00

http://piwigo.org/forum/viewtopic.php?id=26002
The same question at least every month

http://piwigo.org/forum/viewtopic.php?id=26002 The same question at least every month

adam commented

2026-10-04 23:53:58 +02:00

"I suggest to at least remove any reference to the "file" possibility in the comment"
+1

"I suggest to at least remove any reference to the "file" possibility in the comment" +1

adam commented

2026-10-04 23:53:59 +02:00

Instead of completely removing the "file" available value, we could rewrite the comment like this:

picture_url_style : one of 'id' (default) or 'id-file'. 'id-file' means that the file name (without extension) will appear in the url. You can also use 'file', without the id, but beware that you will encounter navigation issues if your file names are not unique. Moreover, 'file' value will lead to one aditionnal sql query (lower speed).

Instead of completely removing the "file" available value, we could rewrite the comment like this: picture_url_style : one of 'id' (default) or 'id-file'. 'id-file' means that the file name (without extension) will appear in the url. You can also use 'file', without the id, but beware that you will encounter navigation issues if your file names are not unique. Moreover, 'file' value will lead to one aditionnal sql query (lower speed).

adam commented

2026-10-04 23:54:00 +02:00

Hello, is it not possible to add a section to admin to check if filenames
are unique?

2015-10-20 9:46 GMT-02:00 Pierrick Le Gall notifications@github.com:

Instead of completely removing the "file" available value, we could
rewrite the comment like this:

picture_url_style : one of 'id' (default) or 'id-file'. 'id-file' means
that the file name (without extension) will appear in the url. You can also
use 'file', without the id, but beware that you will encounter navigation
issues if your file names are not unique. Moreover, 'file' value will lead
to one aditionnal sql query (lower speed).

—
Reply to this email directly or view it on GitHub
https://github.com/Piwigo/Piwigo/issues/362#issuecomment-149536345.

Hello, is it not possible to add a section to admin to check if filenames are unique? 2015-10-20 9:46 GMT-02:00 Pierrick Le Gall notifications@github.com: > Instead of completely removing the "file" available value, we could > rewrite the comment like this: > > picture_url_style : one of 'id' (default) or 'id-file'. 'id-file' means > that the file name (without extension) will appear in the url. You can also > use 'file', without the id, but beware that you will encounter navigation > issues if your file names are not unique. Moreover, 'file' value will lead > to one aditionnal sql query (lower speed). > > — > Reply to this email directly or view it on GitHub > https://github.com/Piwigo/Piwigo/issues/362#issuecomment-149536345.

adam commented

2026-10-04 23:54:00 +02:00

@masakik on page [Administration > Photos > Batch Manager] you can already check for duplicates "by file name".

But, following this idea, we could add a check on admin.php :

if ('file' == $conf['picture_url_style'])
{
// warn for duplicates
}

@masakik on page [Administration > Photos > Batch Manager] you can already check for duplicates "by file name". But, following this idea, we could add a check on admin.php : if ('file' == $conf['picture_url_style']) { // warn for duplicates }

Sign in to join this conversation.

master

issue-2560-people

translation

16.x

feat/embedding-based-contextual-tagging

issue-2576-search-include-ai-in-search-results

feat/search-ocr-ai

issue-2391-update-menu-design

15.x

detect-container

issue-2386-update-filters-users-activity

issue-2362-add-filters-options-in-admin

issue-2367-imagemagick7

issue-2225-quicksearch-help

14.x

issue-2164-BatchManagerUnitMode-Redesign

13.x

12.x

issue-1657-SVG_Support

issue-1703-historySearchMethod

11.x

2.10

2.9

2.8

2.7

2.5

2.6

2.4

2.3

2.2

2.1

2.0

1.7

1.3

1.6

1.5

1.4

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/Piwigo#359