adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

[upload] getimagesize() on php on windows returns no width and height for mp4 files #308

New Issue
Open
opened 2026-10-04 23:51:35 +02:00 by adam · 2 comments
adam commented 2026-10-04 23:51:35 +02:00
Owner
Copy link
Copy source

Reported by xbgmsharp on 2 Mar 2015 14:11

Version: 2.7.4

From https://github.com/xbgmsharp/piwigo-videojs/issues/45

In /admin/include/functions_upload.inc.php I have changed the function pwg_image_infos($path).
This is necessary because getimagesize() on php on windows no width and height for mp4 files returns.
getimagesize() on php on windows heigth and width are empty (not 0, but empty) on Windows

Steps to reproduce: For video upload I use the web form in the admin menu (Photos - Add), with a small video named test_9mb.mp4.
Just before the upload of the video is done the function
add_uploaded_file("./upload/buffer\test_9mb.mp4", "test_9mb.mp4", .....
is called (in /admin/include/functions_upload.inc.php).
This function calls $file_infos = pwg_image_infos("././upload/2015/02/28/20150228204355-3b12953d.mp4");
In this function is getimagesize with the mp4 video used, that does not work (see my changes in this function, I use ffmepg).

Additional information: /* function changed by photonensammler because getimagesize() on windows returns no width and height für video files /
/ ffmpeg must be installed !!! */

function pwg_image_infos($path) {
    global $conf;
    $size = getimagesize($path);
    if (($size === FALSE || $size == 0) && isset($conf['vjs_sync'])) { //use ffmepg to get the size
        $ffmpeg = unserialize($conf['vjs_sync']);
        $ffmpeg_return = shell_exec($ffmpeg['ffmpeg'] . ' -i "' . $path . '" -vstats 2>&1');
        $regex_sizes = "/([0-9]{1,4})x([0-9]{1,4})/";
        preg_match($regex_sizes, $ffmpeg_return, $regs);
        $size = explode('x', $regs[0]);
    }
    list($width, $height) = $size;
    $filesize = floor(filesize($path) / 1024);
    return array(
        'width' => $width,
        'height' => $height,
        'filesize' => $filesize,
    );
}

Piwigo Bugtracker #3208

**Reported by xbgmsharp on 2 Mar 2015 14:11** **Version:** 2.7.4 From https://github.com/xbgmsharp/piwigo-videojs/issues/45 In /admin/include/functions_upload.inc.php I have changed the function pwg_image_infos($path). This is necessary because getimagesize() on php on windows no width and height for mp4 files returns. getimagesize() on php on windows heigth and width are empty (not 0, but empty) on Windows **Steps to reproduce:** For video upload I use the web form in the admin menu (Photos - Add), with a small video named test_9mb.mp4. Just before the upload of the video is done the function add_uploaded_file(&quot;./upload/buffer\test_9mb.mp4&quot;, &quot;test_9mb.mp4&quot;, ..... is called (in /admin/include/functions_upload.inc.php). This function calls $file_infos = pwg_image_infos(&quot;././upload/2015/02/28/20150228204355-3b12953d.mp4&quot;); In this function is getimagesize with the mp4 video used, that does not work (see my changes in this function, I use ffmepg). **Additional information:** /\* function changed by photonensammler because getimagesize() on windows returns no width and height für video files _/ /_ ffmpeg must be installed !!! */ ``` function pwg_image_infos($path) { global $conf; $size = getimagesize($path); if (($size === FALSE || $size == 0) &amp;&amp; isset($conf[&#039;vjs_sync&#039;])) { //use ffmepg to get the size $ffmpeg = unserialize($conf[&#039;vjs_sync&#039;]); $ffmpeg_return = shell_exec($ffmpeg[&#039;ffmpeg&#039;] . &#039; -i &quot;&#039; . $path . &#039;&quot; -vstats 2&gt;&amp;1&#039;); $regex_sizes = &quot;/([0-9]{1,4})x([0-9]{1,4})/&quot;; preg_match($regex_sizes, $ffmpeg_return, $regs); $size = explode(&#039;x&#039;, $regs[0]); } list($width, $height) = $size; $filesize = floor(filesize($path) / 1024); return array( &#039;width&#039; =&gt; $width, &#039;height&#039; =&gt; $height, &#039;filesize&#039; =&gt; $filesize, ); } ``` [Piwigo Bugtracker #3208](http://piwigo.org/bugs/view.php?id=3208) <!-- github-sync-id:97227085 -->
adam commented 2026-10-04 23:51:36 +02:00
Author
Owner
Copy link
Copy source

Comment posted by xbgmsharp on 3 Mar 2015 14:41

I think i find a work around.
https://github.com/xbgmsharp/piwigo-videojs/commit/8396f719d105c440b260d09725a830cd65a7c1be

When confirm we could close this ticket.
However it is interesting to keep in mind as it is a windows specific issue.

**Comment posted by xbgmsharp on 3 Mar 2015 14:41** I think i find a work around. https://github.com/xbgmsharp/piwigo-videojs/commit/8396f719d105c440b260d09725a830cd65a7c1be When confirm we could close this ticket. However it is interesting to keep in mind as it is a windows specific issue. <!-- github-comment-id:124899226 -->
adam commented 2026-10-04 23:51:37 +02:00
Author
Owner
Copy link
Copy source

I still have problem with getimagesize() returning empty width and height for mp4 on Windows (https://github.com/xbgmsharp/piwigo-videojs/issues/45). I don't understand how this works for others as looking at php getimagesize function (http://php.net/manual/en/function.getimagesize.php) it is only meant for image file and not video file?

I still have problem with getimagesize() returning empty width and height for mp4 on Windows (https://github.com/xbgmsharp/piwigo-videojs/issues/45). I don't understand how this works for others as looking at php getimagesize function (http://php.net/manual/en/function.getimagesize.php) it is only meant for image file and not video file? <!-- github-comment-id:140346415 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#308