[other] Function add_url_params returns invalid encoded url #298

New Issue

2026-10-04T23:51:07+02:00

adam commented

2026-10-04 23:51:07 +02:00

Reported by thimo on 30 Jan 2015 15:43

The parameter "$arg_separator" of function "add_url_params" in file include/functions_url.inc.php (line 88) should default to "&" instead "&". Also each value should be url encoded:

/**

adds one or more _GET style parameters to an url
example: add_url_params('/x', array('a'=>'b')) returns /x?a=b
add_url_params('/x?cat_id=10', array('a'=>'b')) returns /x?cat_id=10&a=b
@param string url
@param array params
@return string
*/
function add_url_params($url, $params, $arg_separator='&' )
{
if ( !empty($params) )
{
assert( is_array($params) );
$is_first = true;
foreach($params as $param=>$val)
{
if ($is_first)
{
$is_first = false;
$url .= ( strpos($url, '?')===false ) ? '?' : $arg_separator;
}
else
{
$url .= $arg_separator;
}
$url .= $param;
if (isset($val))
{
$url .= '='.urlencode($val);
}
}
}
return $url;
}

Piwigo Bugtracker #3193

**Reported by thimo on 30 Jan 2015 15:43** The parameter "$arg_separator" of function "add_url_params" in file include/functions_url.inc.php (line 88) should default to "&" instead "&". Also each value should be url encoded: /** - adds one or more _GET style parameters to an url - example: add_url_params('/x', array('a'=>'b')) returns /x?a=b - add_url_params('/x?cat_id=10', array('a'=>'b')) returns /x?cat_id=10&a=b - @param string url - @param array params - @return string */ function add_url_params($url, $params, $arg_separator='&' ) { if ( !empty($params) ) { assert( is_array($params) ); $is_first = true; foreach($params as $param=>$val) { if ($is_first) { $is_first = false; $url .= ( strpos($url, '?')===false ) ? '?' : $arg_separator; } else { $url .= $arg_separator; } $url .= $param; if (isset($val)) { $url .= '='.urlencode($val); } } } return $url; } [Piwigo Bugtracker #3193](http://piwigo.org/bugs/view.php?id=3193)

adam commented

2026-10-04 23:51:08 +02:00

Comment posted by thimo on 30 Jan 2015 15:44

It should default to "&" instead "& amp;"

**Comment posted by thimo on 30 Jan 2015 15:44** It should default to "&" instead "& amp;"

Sign in to join this conversation.

master

issue-2560-people

translation

16.x

feat/embedding-based-contextual-tagging

issue-2576-search-include-ai-in-search-results

feat/search-ocr-ai

issue-2391-update-menu-design

15.x

detect-container

issue-2386-update-filters-users-activity

issue-2362-add-filters-options-in-admin

issue-2367-imagemagick7

issue-2225-quicksearch-help

14.x

issue-2164-BatchManagerUnitMode-Redesign

13.x

12.x

issue-1657-SVG_Support

issue-1703-historySearchMethod

11.x

2.10

2.9

2.8

2.7

2.5

2.6

2.4

2.3

2.2

2.1

2.0

1.7

1.3

1.6

1.5

1.4

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/Piwigo#298