adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

l10n key warnings in admin/picture_modify.php #2220

New Issue
Open
opened 2026-10-05 01:10:10 +02:00 by adam · 1 comment
adam commented 2026-10-05 01:10:10 +02:00
Owner
Copy link
Copy source

When opening an image to edit, the following key warnings are shown:

  • admin/picture_modify.php(273): language key "%s" not defined
  • admin/picture_modify.php(275): language key "4 months ago" not defined
  • admin/picture_modify.php(279): language key "31" not defined

This is with Git version 2357a86d51

When opening an image to edit, the following key warnings are shown: * admin/picture_modify.php(273): language key "%s" not defined * admin/picture_modify.php(275): language key "4 months ago" not defined * admin/picture_modify.php(279): language key "31" not defined This is with Git version 2357a86d51b315b846884e9f77076a82ccdbd1f2 <!-- github-sync-id:4606011201 -->
adam commented 2026-10-05 01:10:11 +02:00
Author
Owner
Copy link
Copy source

The first and last of these probably don't really make sense to be l10n strings, I think:

  • Line 273: 'file' => l10n('%s', $row['file']) This shows only the filename. Perhaps some languages need to wrap it or something?
  • Line 279:'id' => l10n($row['id']) I'm not sure what this is meant to do, unless different languages want to be able to override ID displays or something?

The "4 months ago" presumably could be made localizable, although it might be easier if the numeric part was split out? I'm not really sure.

  • Line 275: 'age' => l10n(ucfirst(time_since($row['date_available'], 'year')))
The first and last of these probably don't really make sense to be l10n strings, I think: * Line 273: `'file' => l10n('%s', $row['file'])` This shows only the filename. Perhaps some languages need to wrap it or something? * Line 279:`'id' => l10n($row['id'])` I'm not sure what this is meant to do, unless different languages want to be able to override ID displays or something? The `"4 months ago"` presumably could be made localizable, although it might be easier if the numeric part was split out? I'm not really sure. * Line 275: `'age' => l10n(ucfirst(time_since($row['date_available'], 'year')))` <!-- github-comment-id:4641283807 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#2220