adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-03 07:22:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

check for new Piwigo versions generates too many requests on piwigo.org #2170

New Issue
Closed
opened 2026-10-05 01:08:36 +02:00 by adam · 0 comments
adam commented 2026-10-05 01:08:36 +02:00
Owner
Copy link
Copy source

After #2134 we have implemented a mechanism to block a Piwigo installation performing too many requests on piwigo.org to fetch the version list. By exploring the logs today, I realize we still have many blocked Piwigo. The requests looks like:

MariaDB [piwigo_site]> select * from all_versions_requests where origin='dc666919e8db219634c286a8497f68e188e10adf' order by occured_on desc;
+------------------------------------------+---------------------+
| origin                                   | occured_on          |
+------------------------------------------+---------------------+
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
| dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 |
+------------------------------------------+---------------------+
11 rows in set (0.001 sec)

As we can see, all requests in the same second.

I can't be sure, but maybe it's a highly visited Piwigo. If 10 visitors open a page at the same time, as $conf['update_notify_last_check'] will be outdated for all of them, they will all perform the request to piwigo.org.

Let's add our unique_exec system (as for send_piwigo_infos.

After #2134 we have implemented a mechanism to block a Piwigo installation performing too many requests on piwigo.org to fetch the version list. By exploring the logs today, I realize we still have many blocked Piwigo. The requests looks like: ``` MariaDB [piwigo_site]> select * from all_versions_requests where origin='dc666919e8db219634c286a8497f68e188e10adf' order by occured_on desc; +------------------------------------------+---------------------+ | origin | occured_on | +------------------------------------------+---------------------+ | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | | dc666919e8db219634c286a8497f68e188e10adf | 2026-01-04 20:35:16 | +------------------------------------------+---------------------+ 11 rows in set (0.001 sec) ``` As we can see, all requests in the same second. I can't be sure, but maybe it's a highly visited Piwigo. If 10 visitors open a page at the same time, as `$conf['update_notify_last_check']` will be outdated for all of them, they will all perform the request to piwigo.org. Let's add our unique_exec system (as for `send_piwigo_infos`. <!-- github-sync-id:3779579334 -->
adam closed this issue 2026-10-05 01:08:36 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#2170