adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-31 06:02:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

[template] Move hardcoded html entirely to templates #205

New Issue
Closed
opened 2026-10-04 23:47:14 +02:00 by adam · 3 comments
adam commented 2026-10-04 23:47:14 +02:00
Owner
Copy link
Copy source

Reported by Matthes0815 on 22 Oct 2012 15:16

Version: 2.4.5

Currently it is nearly impossible to create a valid website with strict doctype.
Too much html is still generated inside the functions and therefore not easy to edit and maintain.

For example:
template.class.php writes the combined css with <link> where it should be <link /> for a strict doctype. I'd have to change the php file and would lose it on updates.

Piwigo Bugtracker #2776

**Reported by Matthes0815 on 22 Oct 2012 15:16** **Version:** 2.4.5 Currently it is nearly impossible to create a valid website with strict doctype. Too much html is still generated inside the functions and therefore not easy to edit and maintain. For example: template.class.php writes the combined css with &lt;link&gt; where it should be &lt;link /&gt; for a strict doctype. I&#039;d have to change the php file and would lose it on updates. [Piwigo Bugtracker #2776](http://piwigo.org/bugs/view.php?id=2776) <!-- github-sync-id:97226476 -->
adam closed this issue 2026-10-04 23:47:14 +02:00
adam commented 2026-10-04 23:47:15 +02:00
Author
Owner
Copy link
Copy source

Comment posted by mistic100 on 27 Oct 2012 12:21

as we have switched to the HTML5 doctype for Piwigo 2.5 I don't think this is still relevant

**Comment posted by mistic100 on 27 Oct 2012 12:21** as we have switched to the HTML5 doctype for Piwigo 2.5 I don&#039;t think this is still relevant <!-- github-comment-id:124892928 -->
adam commented 2026-10-04 23:47:15 +02:00
Author
Owner
Copy link
Copy source

Comment posted by Matthes0815 on 27 Oct 2012 12:41

Well, it's at least still bad style...
It should be in the template's choice, which doctype gets used. I like to use XHTML and create my own little template, but I have to edit core files to make it valid - especially if I want to serve it with the right mime type "application/xml" or "application/xhtml+xml".

It's not a big thing to move the entire html to template files. Instead of assigning the whole link-tag for the combined css there could be the link-tag inside the template and template.class.php just assigns the new src.

**Comment posted by Matthes0815 on 27 Oct 2012 12:41** Well, it&#039;s at least still bad style... It should be in the template&#039;s choice, which doctype gets used. I like to use XHTML and create my own little template, but I have to edit core files to make it valid - especially if I want to serve it with the right mime type &quot;application/xml&quot; or &quot;application/xhtml+xml&quot;. It&#039;s not a big thing to move the entire html to template files. Instead of assigning the whole link-tag for the combined css there could be the link-tag inside the template and template.class.php just assigns the new src. <!-- github-comment-id:124892940 -->
adam commented 2026-10-04 23:47:16 +02:00
Author
Owner
Copy link
Copy source

We can't keep this issue as it is, simply because it's not precise enough. This issue will never be closed (which is the purpose of all issues)

We can't keep this issue as it is, simply because it's not precise enough. This issue will never be closed (which is the purpose of all issues) <!-- github-comment-id:215341301 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#205