adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-31 06:02:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

incorrect sort of generated md5sum #2015

New Issue
Closed
opened 2026-10-05 01:03:58 +02:00 by adam · 1 comment
adam commented 2026-10-05 01:03:58 +02:00
Owner
Copy link
Copy source

When computing md5sums for photos having images.md5sum=null (basically all photos added by sync), the add_md5sum function randomly assign md5sum to provided list of photo ids. If you ask to add the md5um to 10 photos, photo number 2 might get the md5sum of photo 7... Not good.

We haven't seen the problem in 7 years because Piwigo only searches for missing md5sums. Not "inaccurate" md5sums. This might change in the future with advanced file integrity checks.

When computing md5sums for photos having `images.md5sum=null` (basically all photos added by sync), the `add_md5sum` function randomly assign md5sum to provided list of photo ids. If you ask to add the md5um to 10 photos, photo number 2 might get the md5sum of photo 7... Not good. We haven't seen the problem in 7 years because Piwigo only searches for missing md5sums. Not "inaccurate" md5sums. This might change in the future with advanced file integrity checks. <!-- github-sync-id:2827876855 -->
adam closed this issue 2026-10-05 01:03:58 +02:00
adam commented 2026-10-05 01:03:59 +02:00
Author
Owner
Copy link
Copy source

In https://github.com/plegall/Piwigo-virtualize/commit/03be498a8c118d40b7843798cc526e9604aaf449 I have decided to forbid virtualization if you have missing md5sums

In https://github.com/plegall/Piwigo-virtualize/commit/03be498a8c118d40b7843798cc526e9604aaf449 I have decided to forbid virtualization if you have missing md5sums <!-- github-comment-id:3065663669 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#2015