adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

more than one email notification on new Piwigo version available #1852

New Issue
Closed
opened 2026-10-05 00:58:42 +02:00 by adam · 1 comment
adam commented 2026-10-05 00:58:42 +02:00
Owner
Copy link
Copy source

Every $conf['update_notify_check_period'] (default = 24 hours) Piwigo sends a requests to piwigo.org to list the versions of Piwigo currently available. If the current Piwigo is behind the latest version available on piwigo.org, Piwigo sends an email notification to the webmasters. To make sure Piwigo does not check piwigo.org too often (and sends an email to webmasters), it relies on the configuration parameter update_notify_last_check which is written by function notify_piwigo_new_versions:

conf_update_param('update_notify_last_check', date('c'));

If, for any reason, Piwigo fails to write this line in the database, Piwigo may not crash and continue to execute remaining code, thus notifiying webmasters... Even with a read-only database, I haven't been able to fully reproduce this bug, because my Piwigo stops as soon as the insert/update in the config table fails. Some users report that it does not crash for them and that they get dozens, or even thousands emails "a new version of Piwigo is available". Perfectly annoying!

https://fr.piwigo.org/forum/viewtopic.php?id=30404
https://piwigo.org/forum/viewtopic.php?id=33511

Every `$conf['update_notify_check_period']` (default = 24 hours) Piwigo sends a requests to piwigo.org to list the versions of Piwigo currently available. If the current Piwigo is behind the latest version available on piwigo.org, Piwigo sends an email notification to the webmasters. To make sure Piwigo does not check piwigo.org too often (and sends an email to webmasters), it relies on the configuration parameter `update_notify_last_check` which is written by function `notify_piwigo_new_versions`: ``` conf_update_param('update_notify_last_check', date('c')); ``` If, for any reason, Piwigo fails to write this line in the database, Piwigo may not crash and continue to execute remaining code, thus notifiying webmasters... Even with a read-only database, I haven't been able to fully reproduce this bug, because my Piwigo stops as soon as the `insert/update` in the config table fails. Some users report that it does not crash for them and that they get dozens, or even thousands emails "a new version of Piwigo is available". Perfectly annoying! https://fr.piwigo.org/forum/viewtopic.php?id=30404 https://piwigo.org/forum/viewtopic.php?id=33511 <!-- github-sync-id:2183600561 -->
adam closed this issue 2026-10-05 00:58:42 +02:00
adam commented 2026-10-05 00:58:43 +02:00
Author
Owner
Copy link
Copy source

As a first step, we have modified piwigo.org so that it detects servers performing too many requests to get Piwigo available versions. More than X requests within Y minutes will lead to a 24 hours quarantine.

As a first step, we have modified piwigo.org so that it detects servers performing too many requests to get Piwigo available versions. More than X requests within Y minutes will lead to a 24 hours quarantine. <!-- github-comment-id:1994023165 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1852