adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

Crashes when uploading a photo that is already present #1834

New Issue
Closed
opened 2026-10-05 00:58:12 +02:00 by adam · 0 comments
adam commented 2026-10-05 00:58:12 +02:00
Owner
Copy link
Copy source

Tested with Piwigo 14.1 and 14.2
When a photo already present on the server is re-uploaded, the server crashes with the following trace log:

2024/02/03 16:31:46 [error] 302#302: *399 FastCGI sent in stderr: "PHP message: PHP Fatal error: 
Uncaught mysqli_sql_exception: Duplicate entry '66-2' for key 'PRIMARY' in
include/dblayer/functions_mysqli.inc.php:132

Stack trace:
#0 include/dblayer/functions_mysqli.inc.php(132): mysqli->query()
#1 include/dblayer/functions_mysqli.inc.php(550): pwg_query()
#2 admin/include/functions.php(1914): mass_inserts()
#3 admin/include/functions_upload.inc.php(444): fill_lounge()
#4 admin/include/functions_upload.inc.php(179): add_uploaded_file_add_to_categories()
#5 include/ws_functions/pwg.images.php(1852): add_uploaded_file()
#6 include/ws_core.inc.php(600): ws_images_uploadAsync()
#7 include/ws_protocols/rest_handler.php(41): PwgServer->invoke()
#8 include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest()
#9 ws.php(22): PwgServer->run()
#10 {main}
  thrown in include/dbl" while reading response header from upstream, client: ###:###:###:###,
server: _, request: "POST /ws.php?format=json&method=pwg.images.uploadAsync HTTP/1.1",
upstream: "fastcgi://127.0.0.1:####", host: "###:###:###:###:#####"

The server returns the error 500 to the method pwg.images.uploadAsync, as if an error was encountered during the transfer. The third party app concludes that the upload fails and might be repeated.

Ideally, the server should return errors with codes different than a generic error 500 when a transfer fails, for example somthing like:

  • 530 "error during buffer directory creation"
  • 531 "MD5 checksum chunk file mismatched"
  • 532 "error while creating merged…"
  • 533 "error while locking merged…"
  • 534 "error while merging chunk…"

This would prevent the third party app to allow re-uploading.

Tested with Piwigo 14.1 and 14.2 When a photo already present on the server is re-uploaded, the server crashes with the following trace log: ``` 2024/02/03 16:31:46 [error] 302#302: *399 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught mysqli_sql_exception: Duplicate entry '66-2' for key 'PRIMARY' in include/dblayer/functions_mysqli.inc.php:132 Stack trace: #0 include/dblayer/functions_mysqli.inc.php(132): mysqli->query() #1 include/dblayer/functions_mysqli.inc.php(550): pwg_query() #2 admin/include/functions.php(1914): mass_inserts() #3 admin/include/functions_upload.inc.php(444): fill_lounge() #4 admin/include/functions_upload.inc.php(179): add_uploaded_file_add_to_categories() #5 include/ws_functions/pwg.images.php(1852): add_uploaded_file() #6 include/ws_core.inc.php(600): ws_images_uploadAsync() #7 include/ws_protocols/rest_handler.php(41): PwgServer->invoke() #8 include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest() #9 ws.php(22): PwgServer->run() #10 {main} thrown in include/dbl" while reading response header from upstream, client: ###:###:###:###, server: _, request: "POST /ws.php?format=json&method=pwg.images.uploadAsync HTTP/1.1", upstream: "fastcgi://127.0.0.1:####", host: "###:###:###:###:#####" ``` The server returns the error 500 to the method `pwg.images.uploadAsync`, as if an error was encountered during the transfer. The third party app concludes that the upload fails and might be repeated. Ideally, the server should return errors with codes different than a generic error 500 when a transfer fails, for example somthing like: - 530 "error during buffer directory creation" - 531 "MD5 checksum chunk file mismatched" - 532 "error while creating merged…" - 533 "error while locking merged…" - 534 "error while merging chunk…" This would prevent the third party app to allow re-uploading. <!-- github-sync-id:2117205665 -->
adam closed this issue 2026-10-05 00:58:12 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1834