history.section autofill should not be case sensitive #1813

New Issue

2026-10-05T00:57:38+02:00

adam commented

2026-10-05 00:57:38 +02:00

In this code (include/functions.inc.php function pwg_log:

  // If plugin developers add their own sections, Piwigo will automatically add it in the history.section enum column
  if (isset($page['section']))
  {
    // set cache if not available
    if (!isset($conf['history_sections_cache']))
    {
      conf_update_param('history_sections_cache', get_enums(HISTORY_TABLE, 'section'), true);
    }

    $conf['history_sections_cache'] = safe_unserialize($conf['history_sections_cache']);

    if (in_array($page['section'], $conf['history_sections_cache']))
    {
      $section = $page['section'];
    }
    elseif (preg_match('/^[a-zA-Z0-9_-]+$/', $page['section']))
    {
      $history_sections = get_enums(HISTORY_TABLE, 'section');
      $history_sections[] = $page['section'];

      // alter history table structure, to include a new section
      pwg_query('ALTER TABLE '.HISTORY_TABLE.' CHANGE section section enum(\''.implode("','", array_unique($history_sections)).'\') DEFAULT NULL;');

      // and refresh cache
      conf_update_param('history_sections_cache', get_enums(HISTORY_TABLE, 'section'), true);

      $section = $page['section'];
    }
  }

We do as if the history.section is case sensitive. It's not. If you try to add section42 in the ENUM field while Section42 already exists, MySQL will throw an error.

In this code (`include/functions.inc.php` function `pwg_log`: ``` // If plugin developers add their own sections, Piwigo will automatically add it in the history.section enum column if (isset($page['section'])) { // set cache if not available if (!isset($conf['history_sections_cache'])) { conf_update_param('history_sections_cache', get_enums(HISTORY_TABLE, 'section'), true); } $conf['history_sections_cache'] = safe_unserialize($conf['history_sections_cache']); if (in_array($page['section'], $conf['history_sections_cache'])) { $section = $page['section']; } elseif (preg_match('/^[a-zA-Z0-9_-]+$/', $page['section'])) { $history_sections = get_enums(HISTORY_TABLE, 'section'); $history_sections[] = $page['section']; // alter history table structure, to include a new section pwg_query('ALTER TABLE '.HISTORY_TABLE.' CHANGE section section enum(\''.implode("','", array_unique($history_sections)).'\') DEFAULT NULL;'); // and refresh cache conf_update_param('history_sections_cache', get_enums(HISTORY_TABLE, 'section'), true); $section = $page['section']; } } ``` We do as if the `history.section` is case sensitive. It's not. If you try to add `section42` in the ENUM field while `Section42` already exists, MySQL will throw an error.

adam closed this issue

2026-10-05 00:57:38 +02:00

Sign in to join this conversation.

master

issue-2560-people

translation

16.x

feat/embedding-based-contextual-tagging

issue-2576-search-include-ai-in-search-results

feat/search-ocr-ai

issue-2391-update-menu-design

15.x

detect-container

issue-2386-update-filters-users-activity

issue-2362-add-filters-options-in-admin

issue-2367-imagemagick7

issue-2225-quicksearch-help

14.x

issue-2164-BatchManagerUnitMode-Redesign

13.x

12.x

issue-1657-SVG_Support

issue-1703-historySearchMethod

11.x

2.10

2.9

2.8

2.7

2.5

2.6

2.4

2.3

2.2

2.1

2.0

1.7

1.3

1.6

1.5

1.4

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/Piwigo#1813