adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

[search] a specific search can be changed after being shared #1741

New Issue
Closed
opened 2026-10-05 00:55:08 +02:00 by adam · 0 comments
adam commented 2026-10-05 00:55:08 +02:00
Owner
Copy link
Copy source

With Piwigo 14.0.0beta3 (starting with beta1) we have implemented a new search system. One important decision in this new design is that a search can be "updated" with API method pwg.images.filteredSearch.update.

Now let's take an example when it's a real problem:

  1. on monday morning, Peter copies the url of his search http://domain/index.php?/search/psk-20230927-QD6IP9evVB and sends it to Matthew by email
  2. on tuesday, Peter keeps working on this search, adds some filters and modify previously added filters
  3. on wednesday, Matthew clicks on the link and will see the updated search of tueday, not the search as it was on monday

That's a problem, because Peter certainly thinks that he has copied the search rules "as they are" at the moment of the copy.

Updating a search was an interesting idea, to avoid too many lines in the piwigo_search table, but leads to this kind of user experience issue. We must revert this design decision and create a new search each time a parameter is modified/added/removed.

With Piwigo 14.0.0beta3 (starting with beta1) we have implemented a new search system. One important decision in this new design is that a search can be "updated" with API method `pwg.images.filteredSearch.update`. Now let's take an example when it's a real problem: 1. on monday morning, Peter copies the url of his search `http://domain/index.php?/search/psk-20230927-QD6IP9evVB` and sends it to Matthew by email 2. on tuesday, Peter keeps working on this search, adds some filters and modify previously added filters 3. on wednesday, Matthew clicks on the link and will see the updated search of tueday, not the search as it was on monday That's a problem, because Peter certainly thinks that he has copied the search rules "as they are" at the moment of the copy. Updating a search was an interesting idea, to avoid too many lines in the `piwigo_search` table, but leads to this kind of user experience issue. We must revert this design decision and create a new search each time a parameter is modified/added/removed. <!-- github-sync-id:1915720883 -->
adam closed this issue 2026-10-05 00:55:09 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1741