adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

[search] prevent spying searches made by other users #1705

New Issue
Closed
opened 2026-10-05 00:53:34 +02:00 by adam · 0 comments
adam commented 2026-10-05 00:53:34 +02:00
Owner
Copy link
Copy source

In Piwigo 13 and before, the search url looks like index.php?/search/123. Easy to understand that there is a search 122 and 121 before that. Anybody can perfectly open it and discover what has been searched before. Not the level of privacy we want for Piwigo.

I've been thinking about it (with @MatthieuLP ) and we've decided to switch to a search_uuid system, for example index.php?/search/psk-20230809-thuVvgrfrG where:

  • psk means "piwigo search key'
  • 20230809 is the date
  • thuVvgrfrG is randomly generated

This way, quite impossible to "spy" on other users searches.

Furthermore, with the new search system being prepared for Piwigo 14, a search can be "updated" (in Piwigo 13, you could only created a new search when you wanted to modify search criteria). We have also thought about this issue with @MatthieuLP and concluded:

  1. pwg.images.filteredSearch.update must forbid update if the requester is not the creator of the search
  2. when opening a search url (provided by a coworker for example) that is not ours, fork (duplicate) the search and redirect on its url
In Piwigo 13 and before, the search url looks like `index.php?/search/123`. Easy to understand that there is a search `122` and `121` before that. Anybody can perfectly open it and discover what has been searched before. Not the level of privacy we want for Piwigo. I've been thinking about it (with @MatthieuLP ) and we've decided to switch to a `search_uuid` system, for example `index.php?/search/psk-20230809-thuVvgrfrG` where: - `psk` means "piwigo search key' - `20230809` is the date - `thuVvgrfrG` is randomly generated This way, quite impossible to "spy" on other users searches. Furthermore, with the new search system being prepared for Piwigo 14, a search can be "updated" (in Piwigo 13, you could only created a new search when you wanted to modify search criteria). We have also thought about this issue with @MatthieuLP and concluded: 1. `pwg.images.filteredSearch.update` must forbid update if the requester is not the creator of the search 2. when opening a search url (provided by a coworker for example) that is not ours, fork (duplicate) the search and redirect on its url <!-- github-sync-id:1843703033 -->
adam closed this issue 2026-10-05 00:53:35 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1705