[search] Empty filter deletion is bugged #1698

New Issue

2026-10-05T00:53:21+02:00

adam commented

2026-10-05 00:53:21 +02:00

In the new multi-criteria search when you delete an empty filter and then go to the filter manager and validate the form, on the reload, the deleted filter is back in the filter list.

Reproduce the issue :

Open a filter and click 'Delete' action
Open the filter manager
Click validate

When the page reloads, the filter you deleted should be back.

A semi-fix to this issue is to change $("#addLinkedAlbum").has(e.target).length === 0 to $("#addLinkedAlbum").has(e.target).length !== 0 But it breaks the filter's closing when you click outside them.
For now we choose to keep it as it is because the path to reproduce is unlikely to happen and can be worked around if needed.

In the new multi-criteria search when you delete an empty filter and then go to the filter manager and validate the form, on the reload, the deleted filter is back in the filter list. Reproduce the issue : - Open a filter and click 'Delete' action - Open the filter manager - Click validate When the page reloads, the filter you deleted should be back. A semi-fix to this issue is to change ``` $("#addLinkedAlbum").has(e.target).length === 0 ``` to ``` $("#addLinkedAlbum").has(e.target).length !== 0 ``` But it breaks the filter's closing when you click outside them. For now we choose to keep it as it is because the path to reproduce is unlikely to happen and can be worked around if needed.

adam closed this issue

2026-10-05 00:53:21 +02:00

adam commented

2026-10-05 00:53:22 +02:00

A quick way to solve this would be to trigger the page reload even if the filter we delete is empty.

In mcs.js :
For earch filter .delete").on("click" listenner just change the performSearch() function's second param to true.
It will trigger the reload.

A quick way to solve this would be to trigger the page reload even if the filter we delete is empty. In ```mcs.js``` : For earch filter ```.delete").on("click"``` listenner just change the ```performSearch()``` function's second param to ```true```. It will trigger the reload.

adam commented

2026-10-05 00:53:23 +02:00

Bug fixed with the proposed workaround, see https://github.com/Piwigo/Piwigo/commit/f62d255e0ab689d8195bc7d19c16811b3f9560b3

Bug fixed with the proposed workaround, see https://github.com/Piwigo/Piwigo/commit/f62d255e0ab689d8195bc7d19c16811b3f9560b3

Sign in to join this conversation.

master

issue-2560-people

translation

16.x

feat/embedding-based-contextual-tagging

issue-2576-search-include-ai-in-search-results

feat/search-ocr-ai

issue-2391-update-menu-design

15.x

detect-container

issue-2386-update-filters-users-activity

issue-2362-add-filters-options-in-admin

issue-2367-imagemagick7

issue-2225-quicksearch-help

14.x

issue-2164-BatchManagerUnitMode-Redesign

13.x

12.x

issue-1657-SVG_Support

issue-1703-historySearchMethod

11.x

2.10

2.9

2.8

2.7

2.5

2.6

2.4

2.3

2.2

2.1

2.0

1.7

1.3

1.6

1.5

1.4

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/Piwigo#1698