adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-03 07:22:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

Mysql "Illegal double" Error on ID / File name #1593

New Issue
Open
opened 2026-10-05 00:49:29 +02:00 by adam · 2 comments
adam commented 2026-10-05 00:49:29 +02:00
Owner
Copy link
Copy source

This is an error that occasionally pops up.

I have an image entry in my database that has the following characteristics:

ID = 80079
File = 8362e904.jpg

When you try to access the page for the image, you get the following Mysql error:

[mysql error 1367] Illegal double '8362e904' value found during parsing

SELECT id, file, level
  FROM piwigo_images
  WHERE id = 8362e904 in piwigo/include/dblayer/functions_mysqli.inc.php on line 847

As you can see, the software identifies "8362e904" as the ID and not the file name. It determines that the variable is actually a number, therefore it must be the numerical ID. Can an additional check be added to correctly determine if it is an integer before assuming it is a valid mediumint?

This is an error that occasionally pops up. I have an image entry in my database that has the following characteristics: ID = 80079 File = 8362e904.jpg When you try to access the page for the image, you get the following Mysql error: ``` [mysql error 1367] Illegal double '8362e904' value found during parsing SELECT id, file, level FROM piwigo_images WHERE id = 8362e904 in piwigo/include/dblayer/functions_mysqli.inc.php on line 847 ``` As you can see, the software identifies "8362e904" as the ID and not the file name. It determines that the variable is actually a number, therefore it must be the numerical ID. Can an additional check be added to correctly determine if it is an integer before assuming it is a valid ```mediumint```? <!-- github-sync-id:1493436732 -->
adam commented 2026-10-05 00:49:30 +02:00
Author
Owner
Copy link
Copy source

It appears in picture.php the following code is what checks if a variable is a number or not:

if ($page['image_id']>0)
  {
    $query .= 'id = '.$page['image_id'];
  }

I have run the following PHP tests in multiple versions, with the same result in all:

echo ('8362e904' > 0) ? 'numeric' : 'not numeric';
echo is_numeric('8362e904') ? 'numeric' : 'not numeric';
echo is_numeric(8362e904) ? 'numeric' : 'not numeric';
echo is_int('8362e904') ? 'integer' : 'not integer';
echo is_int(8362e904) ? 'integer' : 'not integer';

The result is:

numeric
numeric
numeric
not integer
not integer

As expected the variable 8362e904 is picked up as a number, but it is not picked up as an integer.

Therefore the fix for this should be to replace the above referenced code with:

if (is_int($page['image_id']))
  {
    $query .= 'id = '.$page['image_id'];
  }
It appears in [picture.php](https://github.com/Piwigo/Piwigo/blob/be63364aa663643a5886d120d754c306dbfa945f/picture.php#L29) the following code is what checks if a variable is a number or not: ``` if ($page['image_id']>0) { $query .= 'id = '.$page['image_id']; } ``` I have run the following PHP tests in multiple versions, with the same result in all: ```` echo ('8362e904' > 0) ? 'numeric' : 'not numeric'; echo is_numeric('8362e904') ? 'numeric' : 'not numeric'; echo is_numeric(8362e904) ? 'numeric' : 'not numeric'; echo is_int('8362e904') ? 'integer' : 'not integer'; echo is_int(8362e904) ? 'integer' : 'not integer'; ```` The result is: ```` numeric numeric numeric not integer not integer ```` As expected the variable ```8362e904``` is picked up as a number, but it is not picked up as an integer. Therefore the fix for this should be to replace the above referenced code with: ``` if (is_int($page['image_id'])) { $query .= 'id = '.$page['image_id']; } ``` <!-- github-comment-id:1347797700 -->
adam commented 2026-10-05 00:49:31 +02:00
Author
Owner
Copy link
Copy source

I realize this probably should be:

if (is_int($page['image_id']) && $page['image_id']>0)
  {
    $query .= 'id = '.$page['image_id'];
  }

You probably still want the check if greater than zero.

I also have seen a ton more places in the code where the greater than zero check is used to determine if the variable is an integer. They should all be changed.

I realize this probably should be: ```` if (is_int($page['image_id']) && $page['image_id']>0) { $query .= 'id = '.$page['image_id']; } ```` You probably still want the check if greater than zero. I also have seen a ton more places in the code where the greater than zero check is used to determine if the variable is an integer. They should all be changed. <!-- github-comment-id:1356382575 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1593