adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-03 07:22:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

impossible to change search_results during handling of event "qsearch_results" #1475

New Issue
Closed
opened 2026-10-05 00:45:23 +02:00 by adam · 2 comments
adam commented 2026-10-05 00:45:23 +02:00
Owner
Copy link
Copy source

I'm currently trying to extend quicksearch to search contents of private fields. For this i use the eventHandler
"qsearch_results" wich allows me to add the so found items to $search_results['items'].
This works, as long as there is no match on the core fields. If there is such a match, then the content of $search_results['items'] wil be overwritten by later code during permission checks.
IMO the handler for qsearch_results should receive a copy of the $ids array, an return a new $ids array (changed or not)
$ids = trigger_change('qsearch_results', $ids, $expression, $qsr);

I'm currently trying to extend quicksearch to search contents of private fields. For this i use the eventHandler "qsearch_results" wich allows me to add the so found items to $search_results['items']. This works, as long as there is no match on the core fields. If there is such a match, then the content of $search_results['items'] wil be overwritten by later code during permission checks. IMO the handler for qsearch_results should receive a copy of the $ids array, an return a new $ids array (changed or not) $ids = trigger_change('qsearch_results', $ids, $expression, $qsr); <!-- github-sync-id:1300328423 -->
adam closed this issue 2026-10-05 00:45:23 +02:00
adam commented 2026-10-05 00:45:24 +02:00
Author
Owner
Copy link
Copy source

Hi @tkempf

That sound good. Can you make a pull-request?

Hi @tkempf That sound good. Can you make a pull-request? <!-- github-comment-id:1180085147 -->
adam commented 2026-10-05 00:45:25 +02:00
Author
Owner
Copy link
Copy source

ok done PR #1688 is online

ok done PR #1688 is online <!-- github-comment-id:1180120681 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1475