[Tag Manager] incorrect number of images when filtering #1192

New Issue

2026-10-05T00:35:29+02:00

adam commented

2026-10-05 00:35:29 +02:00

After changing or clearing the filter, some or even all tags are marked with no photos in the pull down menu. I fixed this bug in the file:

admin/themes/default/js/tags.js

`function updatePage() {
return new Promise((resolve, reject) => {
newPage = actualPage;
dataToDisplay = tagToDisplay();
tagBoxes = $('.tag-box');
$('.pageLoad').fadeIn();;
$('.tag-box, .tag-pagination').animate({ opacity: 0 }, 500).promise().then(() => {

  let displayTags = new Promise((res, rej) => {
    boxToRecycle = Math.min(dataToDisplay.length, tagBoxes.length);

    for (let i = 0; i < boxToRecycle; i++) {
      let tag = dataToDisplay[i];
      recycleTagBox($(tagBoxes[i]), tag.id, tag.name, tag.url_name, tag.counter)
    }

    if (dataToDisplay.length < tagBoxes.length) {
      for (let j = boxToRecycle; j < tagBoxes.length; j++) {
        $(tagBoxes[j]).remove();
      }
    } else if (dataToDisplay.length > tagBoxes.length) {
      for (let j = boxToRecycle; j < dataToDisplay.length; j++) {
        let tag = dataToDisplay[j];
 ->>>       newTag = createTagBox(tag.id, tag.name, tag.url_name, tag.counter);
        newTag.css('opacity', 0);
        $('.tag-container').append(newTag);
        setupTagbox(newTag);
      }
    }`

The call of function "createTagBox" missing a parameter "tag.counter"

After changing or clearing the filter, some or even all tags are marked with no photos in the pull down menu. I fixed this bug in the file: admin/themes/default/js/tags.js `function updatePage() { return new Promise((resolve, reject) => { newPage = actualPage; dataToDisplay = tagToDisplay(); tagBoxes = $('.tag-box'); $('.pageLoad').fadeIn();; $('.tag-box, .tag-pagination').animate({ opacity: 0 }, 500).promise().then(() => { let displayTags = new Promise((res, rej) => { boxToRecycle = Math.min(dataToDisplay.length, tagBoxes.length); for (let i = 0; i < boxToRecycle; i++) { let tag = dataToDisplay[i]; recycleTagBox($(tagBoxes[i]), tag.id, tag.name, tag.url_name, tag.counter) } if (dataToDisplay.length < tagBoxes.length) { for (let j = boxToRecycle; j < tagBoxes.length; j++) { $(tagBoxes[j]).remove(); } } else if (dataToDisplay.length > tagBoxes.length) { for (let j = boxToRecycle; j < dataToDisplay.length; j++) { let tag = dataToDisplay[j]; ->>> newTag = createTagBox(tag.id, tag.name, tag.url_name, tag.counter); newTag.css('opacity', 0); $('.tag-container').append(newTag); setupTagbox(newTag); } }` The call of function "createTagBox" missing a parameter "tag.counter"

adam closed this issue

2026-10-05 00:35:29 +02:00

Sign in to join this conversation.

master

issue-2560-people

translation

16.x

feat/embedding-based-contextual-tagging

issue-2576-search-include-ai-in-search-results

feat/search-ocr-ai

issue-2391-update-menu-design

15.x

detect-container

issue-2386-update-filters-users-activity

issue-2362-add-filters-options-in-admin

issue-2367-imagemagick7

issue-2225-quicksearch-help

14.x

issue-2164-BatchManagerUnitMode-Redesign

13.x

12.x

issue-1657-SVG_Support

issue-1703-historySearchMethod

11.x

2.10

2.9

2.8

2.7

2.5

2.6

2.4

2.3

2.2

2.1

2.0

1.7

1.3

1.6

1.5

1.4

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/Piwigo#1192