mirror of
https://github.com/Piwigo/Piwigo.git
synced 2026-11-03 07:22:22 +01:00
related albums shows forbidden albums #1184
Assignees
adam (Adam Wojcieszonek)
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: adam/Piwigo#1184
Reference in new issue
Block a user
when on an album or a photo that appears in several albums including private albums to which the current user does not have access, the name of these albums is displayed and active in the "related albums" menu .
The related album menu should not show album names to which the current user have no access.
This poses a double problem for me:
piwigo 11.3.0
Hello
it shouldn't and I cannot reproduce
Could you try to reproduce with a simple test setup :
*new users "user A" "user B"
*new private albums: "test A" accessible by "user A" only and "test B" accessible by "user B" only
*upload a picture to "test A" then associate that picture to "test B" also
who see what?
if you're able to reproduce it, please post more details about your extensions and server envrionnement
if you can't, please post more details about your permissions
you can see a example here, on our test deployment :
https://phototheque-test.univ-paris1.fr/index.php?/category/181
you arrive as guest on a public album (album/reportage/blabla), in the "related album" menu, you can see "Dircom/source" and "Dircom/making off" which are private albums you can't access but that shares common images with album/reportage/blabla
Bonjour
I don't see "Dircom/source" and "Dircom/making off" as related albums
could you point out a specific picture?
wait
finally got one https://phototheque-test.univ-paris1.fr/picture.php?/10610/category/181
but that's a tag https://phototheque-test.univ-paris1.fr/index.php?/tags/1057-dircom
No it's not.
A made the test again with new photos and new albums on my local piwigo 11.3.0 install, without any tag around and the result is the same :
again give me a direct link to a problematic picture please
thank you
what is really strange is that I can see the problem on any picture in the album
https://phototheque-test.univ-paris1.fr/index.php?/category/181
and even at the album level.
OH! RIGHT
that's on the menu!! Okay!! My bad ! I was expecting to see that on the "metadata" field at the bottom
How is made that menu? what's that theme? that doesn't sound standard to me. Is that modus?
Because on my installations, I can't reproduce but I'm using standard themes or Stripped based themes
my theme is Bootstrap Darkroom but I think that this is a perfectly standard new feature of piwigo 11 :
https://piwigo.org/release-11.0.0
:)
sorry for being perfectly useless at this point
i'm gonna check the code of that new feature
I confirm there is a bug. I have to work on it. It's problematic (to say the least)
:D no problem, thanks for trying :D
@plegall
around https://github.com/Piwigo/Piwigo/blob/master/include/functions_category.inc.php#L720 I would exclude $user['forbidden_categories'] and $filter['visible_categories'] as in https://github.com/Piwigo/Piwigo/blob/master/include/functions_user.inc.php#L1375
@plegall may I suggest to take into account the Filtering features, currently still used to display newest pictures only? (adding 'visible_categories' => 'category_id', ).
for me it sounds weird to display related albums for pictures which are not displayed
So it means someone still uses this feature?!? I thought it was obsolete.
I won't talk about uses ; I don't know them (but I surely can imagine the use for violent/sexy content), and for me, features can be implemented without an explicit need.
In that case, it's still is an option in admin.php?page=configuration§ion=display, so as long as the link exists and the code behind exists, we have to support it.
And I still think that it's a good feature, unfortunately not user-friendly as it is implemented currently. For me, it belongs to an advanced display options, with a slider to change the recent period, and other filtering options such as using tags. We have ways to search among the content (which needs to be unified: combining albums and tags, just as we can combine tags currently from related tags) but no way to "remove"/filter the content.
(i've just tried to enable it on my family gallery but the icon doesn't show up...)