adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

update Smarty (required for php-8) #1137

New Issue
Closed
opened 2026-10-05 00:32:46 +02:00 by adam · 4 comments
adam commented 2026-10-05 00:32:46 +02:00
Owner
Copy link
Copy source

It appears Piwigo currently ships with a version close to Smarty 3.1.29, based on the change_log.txt file in piwigo/include/smarty .

This is very out of date, and subsequent upstream versions have fixed many bugs including most recently a php-8 compatiblity issue which I am now running into, that was fixed in the latest 3.1.37. Version 3.1.37 is also the first upstream version where php-8 is tested.

There are also some security updates mentioned in the changelog (see version 3.1.32, and 3.1.33-dev-4, bugfix on 21.7.2017 as examples).

Can we please have an updated Smarty commited to the release code to fix these issues?

It appears Piwigo currently ships with a version close to Smarty 3.1.29, based on the change_log.txt file in piwigo/include/smarty . This is very out of date, and subsequent upstream versions have fixed many bugs including most recently a php-8 compatiblity issue which I am now running into, that was fixed in the latest 3.1.37. Version 3.1.37 is also the first upstream version where php-8 is tested. There are also some security updates mentioned in the changelog (see version 3.1.32, and 3.1.33-dev-4, bugfix on 21.7.2017 as examples). Can we please have an updated Smarty commited to the release code to fix these issues? <!-- github-sync-id:797843573 -->
adam closed this issue 2026-10-05 00:32:46 +02:00
adam commented 2026-10-05 00:32:47 +02:00
Author
Owner
Copy link
Copy source

Certainly not on 11.x. Too risky (might break plugins)

For 12.x, it's absolutely possible. We have to check the required PHP version to run the latest Smarty version.

Certainly not on 11.x. Too risky (might break plugins) For 12.x, it's absolutely possible. We have to check the required PHP version to run the latest Smarty version. <!-- github-comment-id:773945170 -->
adam commented 2026-10-05 00:32:47 +02:00
Author
Owner
Copy link
Copy source

Now that version 12.0 is in beta, can this request please be reconsidered? Smarty 3.1.39 is current:

https://www.smarty.net/

A reminder also that there are security vulnerabilities in earlier versions of Smarty which are present in the bundled version included in version 11 of Piwigo.

Now that version 12.0 is in beta, can this request please be reconsidered? Smarty 3.1.39 is current: https://www.smarty.net/ A reminder also that there are security vulnerabilities in earlier versions of Smarty which are present in the bundled version included in version 11 of Piwigo. <!-- github-comment-id:877063317 -->
adam commented 2026-10-05 00:32:48 +02:00
Author
Owner
Copy link
Copy source

@MatthieuLP can you make some test on Piwigo 12beta with latest version of Smarty?

@MatthieuLP can you make some test on Piwigo 12beta with latest version of Smarty? <!-- github-comment-id:884831005 -->
adam commented 2026-10-05 00:32:49 +02:00
Author
Owner
Copy link
Copy source

Smarty updated to version 3.1.39 in e537eac

Smarty updated to version 3.1.39 in e537eac <!-- github-comment-id:894282126 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1137