From 943ab9d1899368624eab924fab59f8af708f9418 Mon Sep 17 00:00:00 2001 From: MaximeBOURMAUD Date: Tue, 19 Sep 2017 11:25:00 +0200 Subject: [PATCH] Issue/747 php notice when changing admin page theme (#774) * Fixes#747 Only variables should be passed by reference * Fixes syntax --- admin.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/admin.php b/admin.php index bb9b91274..af6937881 100644 --- a/admin.php +++ b/admin.php @@ -58,12 +58,14 @@ if (isset($_GET['plugins_new_order'])) if (isset($_GET['change_theme'])) { $admin_themes = array('roma', 'clear'); + $admin_theme_array = array($conf['admin_theme']); + $result = array_diff( + $admin_themes, + $admin_theme_array + ); $new_admin_theme = array_pop( - array_diff( - $admin_themes, - array($conf['admin_theme']) - ) + $result ); conf_update_param('admin_theme', $new_admin_theme);