- new : external authentication in another users table. Previous users table

is divided between users (common properties with any web application) and
  user_infos (phpwebgallery specific informations). External table and
  fields can be configured.

- modification : profile.php is not reachable through administration anymore
  (not useful).

- modification : in profile.php, current password is mandatory only if user
  tries to change his password. Username can't be changed.

- deletion : of obsolete functions get_user_restrictions,
  update_user_restrictions, get_user_all_restrictions, is_user_allowed,
  update_user

- modification : $user['forbidden_categories'] equals at least "-1" so that
  category_id NOT IN ($user['forbidden_categories']) can always be used.

- modification : user_forbidden table becomes user_cache so that not only
  restriction informations can be stored in this table.


git-svn-id: http://piwigo.org/svn/trunk@808 68402e56-0260-453c-a942-63ccdbb3a9ee

include/functions_session.inc.php

@@ -109,28 +109,23 @@ function add_session_id( $url, $redirect = false )
 {
   global $page, $user, $conf;
 
-  if ( $user['has_cookie'] or $conf['apache_authentication']) return $url;
-
-  $amp = '&';
-  if ( $redirect )
-  {
-    $amp = '&';
-  }
-  if ( !$user['is_the_guest'] )
-  {
-    if ( preg_match( '/\.php\?/',$url ) )
-    {
-      return $url.$amp.'id='.$page['session_id'];
-    }
-    else
-    {
-      return $url.'?id='.$page['session_id'];
-    }
-  }
-  else
+  if ($user['is_the_guest']
+      or $user['has_cookie']
+      or $conf['apache_authentication'])
   {
     return $url;
   }
+
+  if (preg_match('/\.php\?/', $url))
+  {
+    $separator = $redirect ? '&' : '&';
+  }
+  else
+  {
+    $separator = '?';
+  }
+
+  return $url.$separator.'id='.$page['session_id'];
 }
 
 // cookie_path returns the path to use for the PhpWebGallery cookie.