issue #2405 update smarty

and made Piwigo compatible with smarty 5.x

admin/cat_list.php

@@ -326,7 +326,8 @@ foreach ($categories as $category)
       'U_ADD_PHOTOS_ALBUM' => $base_url.'photos_add&album='.$category['id'],
       'U_MOVE' => $base_url.'albums#cat-'.$category['id'],
 
-      'IS_VIRTUAL' => empty($category['dir'])
+      'IS_VIRTUAL' => empty($category['dir']),
+      'CAT_ADMIN_ACCESS' => cat_admin_access($category['id']),
     );
 
   if (empty($category['dir']))

admin/cat_modify.php

@@ -187,6 +187,7 @@ $template->assign(
     'CAT_NAME'           => @htmlspecialchars($category['name']),
     'CAT_COMMENT'        => @htmlspecialchars($category['comment']),
     'IS_VISIBLE'          => boolean_to_string($category['visible']),
+    'CAT_ADMIN_ACCESS'   => cat_admin_access($category['id']),
 
     'U_DELETE' => $base_url.'albums',
 

admin/themes/default/template/batch_manager_global.tpl

@@ -64,7 +64,7 @@ jQuery(document).ready(function() {
 var nb_thumbs_page = {$nb_thumbs_page};
 var nb_thumbs_set = {$nb_thumbs_set};
 var applyOnDetails_pattern = "{'on the %d selected photos'|@translate}";
-var all_elements = [{if !empty($all_elements)}{','|@implode:$all_elements}{/if}];
+var all_elements = [{if !empty($all_elements)}{$all_elements|join:","}{/if}];
 
 var selectedMessage_pattern = "{'%d of %d photos selected'|@translate}";
 var selectedMessage_none = "{'No photo selected, %d photos in current set'|@translate}";

admin/themes/default/template/batch_manager_unit.tpl

@@ -236,7 +236,7 @@ pluginValues = [];
 					<span class="orphan-photo"></span>
 					{/if}
 					<div class="related-categories-container">
-						{foreach from=$element.related_categories item=$cat_path key=$key}
+						{foreach from=$element.related_categories item=cat_path key=key}
 						<div class="breadcrumb-item">
 							<span class="link-path">{$cat_path['name']}</span>
 							{if $cat_path['unlinkable']}

admin/themes/default/template/cat_list.tpl

@@ -57,7 +57,7 @@ jQuery(document).ready(function(){
       <a href="{$category.U_EDIT}" class="actionEdit" {*title="{'Edit'|@translate}"*}><span class="icon-pencil tiptip" title="{'Edit'|@translate}"></span><span class="iconLegend">{'Edit'|@translate}</span></a>
       <a href="{$category.U_CHILDREN}" class="actionTitle" {*title="{'sub-albums'|@translate}"*}><span class="icon-sitemap tiptip" title="{'sub-albums'|@translate}"></span><span class="iconLegend">{'sub-albums'|@translate}</span></a>
       <a href="{$category.U_MOVE}" class="actionMove"><span class="icon-move tiptip" title="{'Move'|@translate}"></span><span class="iconLegend">{'Move'|@translate}</span></a>
-      {if cat_admin_access($category.ID)}
+      {if $CAT_ADMIN_ACCESS}
       <a href="{$category.U_JUMPTO}" class="actionGalery" {*title="{'Visit Gallery'|@translate}"*}><span class="icon-eye tiptip" title="{'Visit Gallery'|@translate}"></span><span class="iconLegend">{'Visit Gallery'|@translate}</span></a>
       {else}
       <span href="{$category.U_JUMPTO}" class="actionGalery" {*title="{'This album is private'|@translate}"*}><span class="icon-eye tiptip" title="{'This album is private'|@translate}"></span><span class="iconLegend">{'Visit Gallery'|@translate}</span></span>

admin/themes/default/template/cat_modify.tpl

@@ -176,7 +176,7 @@ const str_modal_ab = '{'New parent album'|@translate}';
 
   <div class="cat-modify-footer">
    <div class="cat-modify-footer-start">
-    {if cat_admin_access($CAT_ID)}
+    {if $CAT_ADMIN_ACCESS}
       <a class="cat-modify-footer-see-out" href="{$U_JUMPTO}"><i class="icon-left-open"></i>{'Open in gallery'|translate}</a>
     {else}
     <a class="tiptip cat-modify-footer-see-out disabled" title="{'ACCESS_5'|translate}" href="#"><i class="icon-left-open"></i>{'Open in gallery'|translate}</a>

admin/themes/default/template/configuration_search.tpl

@@ -77,7 +77,7 @@ for(const filter_name of filters_names){
   <fieldset class="searchConf">
     <legend><span class="icon-equalizer icon-blue rotate-element"></span>{'Filters'|translate}</legend>
     <ul>
-      {foreach from=$search.filters_names item=$filter_name}
+      {foreach from=$search.filters_names item=filter_name}
       <li class="filters-grid">
         <label class="font-checkbox">
           <span class="icon-check"></span>

admin/themes/default/template/picture_formats.tpl

@@ -21,7 +21,7 @@
     </div>
 
     <div class="formats-list" {if (count($FORMATS) == 0)}style="display:none"{/if}>
-        {foreach from=$FORMATS item=$format}
+        {foreach from=$FORMATS item=format}
             <div class="format-card" data-id="{$format["format_id"]}" style="background-image: url('{$IMG_SQUARE_SRC}')">
                 <span class="format-card-size">{'%s MB'|@translate:$format["filesize"]}</span>
                 <div class="format-card-ext"><span>{$format["label"]}</span></div>

admin/themes/default/template/picture_modify.tpl

@@ -174,12 +174,12 @@ const str_assoc_album_ab = '{'Associate to album'|translate|escape:javascript}';
       {/if}
       <br>
       <select class="invisible-related-categories-select" name="associate[]" multiple>
-      {foreach from=$related_categories item=$cat_path key=$key}
+      {foreach from=$related_categories item=cat_path key=key}
         <option selected value="{$key}"></option>
       {/foreach}
       </select>
       <div class="related-categories-container">
-      {foreach from=$related_categories item=$cat_path key=$key}
+      {foreach from=$related_categories item=cat_path key=key}
       <div class="breadcrumb-item"><span class="link-path">{$cat_path['name']}</span>{if $cat_path['unlinkable']}<span id={$key} class="icon-cancel-circled remove-item"></span>{else}<span id={$key} class="icon-help-circled help-item tiptip" title="{'This picture is physically linked to this album, you can\'t dissociate them'|translate}"></span>{/if}</div>
       {/foreach}
       </div>

admin/themes/default/template/plugins_new.tpl

@@ -139,7 +139,7 @@ const str_from_begining = "{"since the beginning"|@translate}";
   data-revision="{$plugin.REVISION_DATE}"
   data-downloads="{$plugin.DOWNLOADS}"
   data-author="{$plugin.AUTHOR}"
-  data-tags="{implode(', ', $plugin.TAGS)}"
+  data-tags="{$plugin.TAGS|join:", "}"
 >
   <div class="pluginContent">
     <div class="pluginImage">
@@ -193,7 +193,7 @@ const str_from_begining = "{"since the beginning"|@translate}";
       </div>
     </div>
     <div class="pluginMoreInfo">
-      <div class="pluginTags tiptip" title="{'Tags'|@translate} : {implode(', ', $plugin.TAGS)}">
+      <div class="pluginTags tiptip" title="{'Tags'|@translate} : {$plugin.TAGS|join:", "}">
       {foreach from=$plugin.TAGS key=tag_id item=tag_label}
         <span data-id="{$tag_id}">{$tag_label}</span>
       {/foreach}

admin/themes/default/template/user_activity.tpl

@@ -135,7 +135,7 @@ var actionInfos_tags_moved = "{'%d tags moved'|translate}";
                     <option value="none">
                         <span class='username_filter'>---</span>
                     </option>
-                    {foreach from=$ulist item=$user}
+                    {foreach from=$ulist item=user}
                         <option value="{$user.id}">
                             <span class='username_filter'>{$user.username}</span>
                             <span class='nb_lines_str'>
@@ -153,7 +153,7 @@ var actionInfos_tags_moved = "{'%d tags moved'|translate}";
                     <option value="none">
                         <span class='action_filter'>---</span>
                     </option>
-                    {foreach from=$ACTIONS item=$action}
+                    {foreach from=$ACTIONS item=action}
                         <option value="{$action.value}">
                             <span class='action_filter'>
                                 {ucfirst($action.object)|translate}