adam/Meck
1
0
Fork 0
mirror of https://github.com/pelgraine/Meck.git synced 2026-08-12 11:42:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fixed buffer flutter overflow issue

Browse Source
This commit is contained in:
pelgraine
2026-02-10 03:23:20 +11:00
parent 6e60c56d48
commit 500f59abca
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/companion_radio/MyMesh.cpp
+4 -1
View File
@@ -1080,17 +1080,20 @@ void MyMesh::handleCmdFrame(size_t len) {
memcpy(&msg_timestamp, &cmd_frame[i], 4); memcpy(&msg_timestamp, &cmd_frame[i], 4);
i += 4; i += 4;
const char *text = (char *)&cmd_frame[i]; const char *text = (char *)&cmd_frame[i];
int text_len = len - i;
if (txt_type != TXT_TYPE_PLAIN) { if (txt_type != TXT_TYPE_PLAIN) {
writeErrFrame(ERR_CODE_UNSUPPORTED_CMD); writeErrFrame(ERR_CODE_UNSUPPORTED_CMD);
} else { } else {
ChannelDetails channel; ChannelDetails channel;
bool success = getChannel(channel_idx, channel); bool success = getChannel(channel_idx, channel);
if (success && sendGroupMessage(msg_timestamp, channel.channel, _prefs.node_name, text, len - i)) { if (success && sendGroupMessage(msg_timestamp, channel.channel, _prefs.node_name, text, text_len)) {
writeOKFrame(); writeOKFrame();
#ifdef DISPLAY_CLASS #ifdef DISPLAY_CLASS
// Show BLE-app-sent message on device channel screen // Show BLE-app-sent message on device channel screen
if (_ui) { if (_ui) {
// Null-terminate text from BLE frame (frame buffer may have residual data)
cmd_frame[i + text_len] = 0;
_ui->addSentChannelMessage(channel_idx, _prefs.node_name, text); _ui->addSentChannelMessage(channel_idx, _prefs.node_name, text);
} }
#endif #endif