From 40ceb82431d6aa6afb24a8ab60a504d06f9dd296 Mon Sep 17 00:00:00 2001
From: KonradIT <github@chernowii.com>
Date: Fri, 4 Oct 2024 15:28:00 +0200
Subject: [PATCH] naming, use int highest value gotten variable for comparison,
 only keep track of frequency ranges if json feature is enabled

---
 src/main.cpp | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/main.cpp b/src/main.cpp
index 2be3d4d..bacbf1e 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -442,11 +442,11 @@ void init_radio()
     delay(50);
 }
 
-struct FrequencyRange
+struct frequency_scan_result
 {
     uint64_t begin;
     uint64_t end;
-} frequencyRange;
+} frequency_scan_result;
 
 void logToSerialTask(void *parameter)
 {
@@ -455,7 +455,7 @@ void logToSerialTask(void *parameter)
 
     for (;;)
     {
-        if (frequencyRange.begin != frequencyRange.end)
+        if (frequency_scan_result.begin != frequency_scan_result.end)
         {
             String max_result = "-999";
             int highest_value_scanned = 999;
@@ -469,13 +469,13 @@ void logToSerialTask(void *parameter)
                     highest_value_scanned = max_x_window[rssi_item];
                 }
             }
-            if (max_result == "-999")
+            if (highest_value_scanned == 999)
             {
                 continue;
             }
 
-            doc["low_range_freq"] = frequencyRange.begin;
-            doc["high_range_freq"] = frequencyRange.end;
+            doc["low_range_freq"] = frequency_scan_result.begin;
+            doc["high_range_freq"] = frequency_scan_result.end;
             doc["value"] = max_result;
 
             serializeJson(doc, jsonOutput);
@@ -1095,9 +1095,10 @@ void loop(void)
                                           max_rssi_x * 2);
                     }
 
-                    frequencyRange.begin = drone_detected_frequency_start;
-                    frequencyRange.end = drone_detected_frequency_end;
-
+#ifdef LOG_DATA_JSON
+                    frequency_scan_result.begin = drone_detected_frequency_start;
+                    frequency_scan_result.end = drone_detected_frequency_end;
+#endif
                     if (DRAW_DETECTION_TICKS == true)
                     {
 // draw vertical line on top of display for "drone detected"